Re: [PATCH] Merge loaded org-persist index with index file contents

2022-12-14 Thread Timothy
Hi All, Since there have been no further comments, I’ve just pushed a tweaked version of this patch (with Max’s comments addressed and with a minor oversight fixed) as 555dacfa8. All the best, Timothy -- Timothy (‘tecosaur’/‘TEC’), Org mode contributor. Learn more about Org mode at

Re: [PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Timothy
Hi Max, > Please, avoid mixing of system clock and filesystem timestamps. > > (file-attribute-modification-time (file-attributes file)) > > should be more reliable. Thanks for the tip, I’ve updated the patch to use this. > In general, I would prefer to avoid relying on timestamps at all,

Re: [PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Max Nikulin
On 11/12/2022 14:59, Timothy wrote: + (setq org-persist--index combined-index +org-persist--index-age (current-time) Please, avoid mixing of system clock and filesystem timestamps. (file-attribute-modification-time (file-attributes file)) should be more reliable. See

[PATCH] Merge loaded org-persist index with index file contents

2022-12-11 Thread Timothy
Hi All, I’ve recently pushed a batch of improvements/fixes to org-persist, particularly with the handling of url containers. Expect to actually see caching of remote images now . I’ve also noticed that the org-persist index is written when Emacs closes, and so this sequence of event can happen: