Re: [PATCH] Re: Re: org-forward-heading-same-level and the invisible-ok argument

2020-08-28 Thread Ihor Radchenko
> The issue with that is that it reintroduces the thing the patch is > trying to fix, as it considers any partially invisible line as fully > invisible (while the opposite should be the case). Oops. Sorry, I wrote that function without much thinking. Indeed, it should be (defun org--line-visible-

Re: [PATCH] Re: Re: org-forward-heading-same-level and the invisible-ok argument

2020-08-28 Thread D
>> + (mapcar #'org-invisible-p >> + (number-sequence (line-beginning-position) >> + (1- (line-end-position) > > This is a bad idea. org--line-visible-p will be called for every single > invisible headline. If you check every single point at every sin

Re: [PATCH] Re: Re: org-forward-heading-same-level and the invisible-ok argument

2020-08-28 Thread Ihor Radchenko
> + (mapcar #'org-invisible-p > + (number-sequence (line-beginning-position) > + (1- (line-end-position) This is a bad idea. org--line-visible-p will be called for every single invisible headline. If you check every single point at every single i

[PATCH] Re: Re: org-forward-heading-same-level and the invisible-ok argument

2020-08-28 Thread D
> I do not think that setting visibility the leading stars is a correct > approach to control the movement commands. After second though about the > issue you raised in the first email, I think that it would make more > sense for org-forward-heading-same-level to check if any part of the > heading