Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-16 Thread Bastien Guerry
Ihor Radchenko writes: > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6954fe93e Thanks! -- Bastien Guerry

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-15 Thread Ihor Radchenko
Bastien Guerry writes: > Ihor Radchenko writes: > >> See the attached tentative patch. > > LGTM. Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6954fe93e -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Bastien Guerry
Ihor Radchenko writes: > See the attached tentative patch. LGTM. >> 2) Also remove the current C-u C-u C-u arg and make it the default >>when a region is active. >> ... >> (2) should be done anyway. > > I studied this further and what you suggest will interfere with >

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Ihor Radchenko
Bastien Guerry writes: > Here is another suggestion: > > 1) Remove the option and make adding the dup link on top the default. > > (1) is because removing this option would be a breaking change, and > inflincting a new option to every user to deal with a hypothetical > use-case does not seem

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-14 Thread Ihor Radchenko
Samuel Wales writes: > i currently want to copy a link location and then paste that link > loadtion. i don't recall theis breaking before. it does now. Please provide more details. (https://orgmode.org/manual/Feedback.html#Feedback) Otherwise, it is very hard to figure out what exactly you

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Samuel Wales
i currently want to copy a link location and then paste that link loadtion. i don't recall theis breaking before. it does now. On 8/13/23, Ihor Radchenko wrote: > Bastien Guerry writes: > >> Here is another suggestion: >> >> 1) Remove the option and make adding the dup link on top the

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Ihor Radchenko
Bastien Guerry writes: > Here is another suggestion: > > 1) Remove the option and make adding the dup link on top the default. > > 2) Also remove the current C-u C-u C-u arg and make it the default >when a region is active. > > (1) is because removing this option would be a breaking change,

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-13 Thread Bastien Guerry
Hi Ihor, Thanks for bearing with me while I discuss something is done, required time and work, and isn't probably a priority. Ihor Radchenko writes: > Bastien Guerry writes: > >> (1) by always store the latest link on top and remove old dups. >> >> (2) always store latest link at the top and

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-11 Thread Ihor Radchenko
Bastien Guerry writes: > (1) by always store the latest link on top and remove old dups. > > (2) always store latest link at the top and remove old dups and allow > to keep dups with 3 universal prefix args. > ... > I'm in favor of option (2) as it deals with the above use-case, and >

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Bastien Guerry
Ihor Radchenko writes: > This would be yet another breaking change... Of course, you're right! Then here are two suggestions, assuming it's best to spare us yet another option: (1) by always store the latest link on top and remove old dups. (2) always store latest link at the top and remove

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Ihor Radchenko
Samuel Wales writes: > i am confused. org-stored-links is a command? what are the known > user needs for storing and pasting links? Typo. Meant to be org-store-link. > i am also unclear on why we have a dedicated paste function as opposed > to kill ring. probably a good reason. but wfm.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-08 Thread Ihor Radchenko
Bastien writes: > Ihor Radchenko writes: > >> * lisp/ol.el (org-link-store-existing): New customization controlling >> how to deal with already stored links. >> (org-store-link): Respect the new customization, allowing duplicates >> to (1) be added anyway; (2) be ignored; (3) be moved to front

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-06 Thread Samuel Wales
i am confused. org-stored-links is a command? what are the known user needs for storing and pasting links? i am also unclear on why we have a dedicated paste function as opposed to kill ring. probably a good reason. but wfm. i merely wanted to store then yank a link. which in bugfix errors

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-08-06 Thread Bastien
Ihor Radchenko writes: > * lisp/ol.el (org-link-store-existing): New customization controlling > how to deal with already stored links. > (org-store-link): Respect the new customization, allowing duplicates > to (1) be added anyway; (2) be ignored; (3) be moved to front of > `org-stored-links'.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-21 Thread Ihor Radchenko
Samuel Wales writes: > On 7/15/23, Ihor Radchenko wrote: >> Applied, onto main. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0dbcf361 > > thank you! will this reach bugfix too? No, because it is a new feature. So, it is for the next release. -- Ihor Radchenko //

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-20 Thread Samuel Wales
On 7/15/23, Ihor Radchenko wrote: > Applied, onto main. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=c0dbcf361 thank you! will this reach bugfix too? -- The Kafka Pandemic A blog about science, health, human rights, and misopathy: https://thekafkapandemic.blogspot.com

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-15 Thread Ihor Radchenko
Ihor Radchenko writes: > From a05e2cc235b10a7096538da4f6ae6d17c82a6b25 Mon Sep 17 00:00:00 2001 > Message-ID: > > From: Ihor Radchenko > Date: Wed, 5 Jul 2023 13:14:56 +0300 > Subject: [PATCH] org-store-link: Move already stored link to front by default Applied, onto main.

Re: [PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-05 Thread Samuel Wales
On 7/5/23, Ihor Radchenko wrote: > Ihor Radchenko writes: > >> What Samuel described is a sequence of M-x org-store-link followed by >> M-x org-insert-all-links. With such workflow, user can expect that the >> links are going to be stored in order. If we are instead shuffle the >> stored links,

[PATCH] Re: what is the purpose of "This link has already been stored"?

2023-07-05 Thread Ihor Radchenko
Ihor Radchenko writes: > What Samuel described is a sequence of M-x org-store-link followed by > M-x org-insert-all-links. With such workflow, user can expect that the > links are going to be stored in order. If we are instead shuffle the > stored links, M-x org-insert-all-links may result in