Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

Nick Savage writes: > Please see the attached updated patch with the changes requested. Thanks. Pushed (37749c165). > + (declare (obsolete "use `org-babel-sql-expand-vars' instead." "Org 9.4")) ... changing "Org 9.4" to "Org 9.5".

Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

Please see the attached updated patch with the changes requested. Nick On 3/4/21 12:25 AM, Kyle Meyer wrote: Nick Savage writes: Hi everyone, See the attached patch. It is a small change to reduce code duplication between ob-sql.el and ob-sqlite.el by reusing org-babel-sql-expand-vars as sug

Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

Nick Savage writes: > Hi everyone, > > See the attached patch. It is a small change to reduce code duplication > between ob-sql.el and ob-sqlite.el by reusing org-babel-sql-expand-vars > as suggested by the FIXME in ob-sqlite.el. Thank you. Looks good, though I think it'd be nice to keep org-b

[PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

Hi everyone, See the attached patch. It is a small change to reduce code duplication between ob-sql.el and ob-sqlite.el by reusing org-babel-sql-expand-vars as suggested by the FIXME in ob-sqlite.el. Thanks, Nick >From 849a1b7417b39abbf0aeb1b241e890470e4111cd Mon Sep 17 00:00:00 2001 From: