Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-04-01 Thread Ihor Radchenko
Max Nikulin writes: >> I have a concern about this test - it will not work on windows or in > > I do not mind to add > > (skip-unless (not (memq system-type '(ms-dos windows-nt > >> non-standard system shells. We should probably disable the test unless >> "printf" can be evaluated in the

Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-04-01 Thread Max Nikulin
On 31/03/2024 15:27, Ihor Radchenko wrote: Max Nikulin writes: +(ert-deftest test-org/format-latex-as-html () + "Test shell special characters escaping in `org-format-latex-as-html'." + (let ((org-latex-to-html-convert-command + "printf \"\" %i")) I have a concern about this test -

Re: [PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-03-31 Thread Ihor Radchenko
Max Nikulin writes: > Is second attachment appropriate to fix the issue or it has some > undesired effects. Thanks! > +(ert-deftest test-org/format-latex-as-html () > + "Test shell special characters escaping in `org-format-latex-as-html'." > + (let ((org-latex-to-html-convert-command > +

[PATCH] Unit tests for function calling MathML converters (Re: Warn about shell-expansion in the docstring of org-latex-to-html-convert-command)

2024-03-09 Thread Max Nikulin
On 09/03/2024 22:23, Max Nikulin wrote: On 08/03/2024 18:16, Ihor Radchenko wrote: Attaching tentative patch that fixes the problem. I propose to add unit tests, see first attachment. I have tried to add some unit tests, but I faced an issue with `org-create-math-formula'. It creates tempor