Hi Kyle,
Great. That sounds like the best solution given that correctness
is more important than performance at the moment. We have a good idea
of how to improve the performance going forward so providing the
correct behavior asap seems like the right thing to do. Thank you very
much for
Tom Gillespie writes:
> Hi Kyle,
> Following up in this thread having investigated the impact of coderefs.
> My conclusion is that coderefs need to be stripped out before they are
> passed to org-confirm-babel-evaluate. They are not present in the
> executed code and removing them is not
Hi Kyle,
Following up in this thread having investigated the impact of coderefs.
My conclusion is that coderefs need to be stripped out before they are
passed to org-confirm-babel-evaluate. They are not present in the
executed code and removing them is not something that a definition
of
Hi Kyle,
Sorry for the slow turnaround time on this one. Having now tested
it, I think that your solution is a much better one for the time
being, so please go ahead and apply it. From this discussion there are
a number of good options for improvements in the future, but my
priority would be to
Tom Gillespie writes:
> On Sun, Jul 19, 2020 at 2:13 PM Kyle Meyer wrote:
>> An option not mentioned above is to replace (nth 1 info) with the
>> expanded body upstream of (when (org-babel-check-evaluate info) ...).
>> Modifying the body in INFO is admittedly not pretty, but it's in line
>>
Hi Kyle,
Thank you for the feedback. In short if modifying (nth 1 info) in place won't
cause a problem then I think it is the way to go. Details below. Best,
Tom
On Sun, Jul 19, 2020 at 2:13 PM Kyle Meyer wrote:
>
> Tom Gillespie writes:
>
> > This is a patch to improve the behavior of
> >
Tom Gillespie writes:
> This is a patch to improve the behavior of
> org-babel-check-confirm-evaluate and the usefulness of
> org-confirm-babel-evaluate when a function is provided.
Thank you.
> This commit changes the behavior of org-babel-check-confirm-evaluate
> so that
!
Tom
From 6d069f9532f44ee9fbc1a0ebdaadcc2eb807f8ec Mon Sep 17 00:00:00 2001
From: Tom Gillespie
Date: Mon, 13 Jul 2020 12:04:18 -0700
Subject: [PATCH] lisp/ob-core.el: pass expanded body to
org-confirm-babel-evaluate
* lisp/ob-core.el (org-babel-get-body-to-eval): New function extracted
from org
