Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Much obliged :) On Tue, Jan 24, 2023 at 1:20 PM Ihor Radchenko wrote: > Aaron Zeng writes: > > > Hi Ihor, I just noticed that this patch only fixes one of the lines > calling > > `string-pad'. There is another callsite below which needs to be removed. > > Oops. Now, should be good. > >

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Ihor Radchenko
Aaron Zeng writes: > Hi Ihor, I just noticed that this patch only fixes one of the lines calling > `string-pad'. There is another callsite below which needs to be removed. Oops. Now, should be good.

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Hi Ihor, I just noticed that this patch only fixes one of the lines calling `string-pad'. There is another callsite below which needs to be removed. On Tue, Jan 24, 2023 at 11:30 AM Aaron Zeng wrote: > Thanks for the quick response, Ihor! > > On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko >

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Aaron Zeng
Thanks for the quick response, Ihor! On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko wrote: > "Aaron L. Zeng" writes: > > > * org-compat.el (org-string-pad): Add compatibility function > > `org-string-pad' for `string-pad', introduced in Emacs 28.1. > > > > * org-agenda.el

Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-24 Thread Ihor Radchenko
"Aaron L. Zeng" writes: > * org-compat.el (org-string-pad): Add compatibility function > `org-string-pad' for `string-pad', introduced in Emacs 28.1. > > * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather > than `string-pad'. > > Since this is more-or-less just copying

[PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

2023-01-23 Thread Aaron L. Zeng
* org-compat.el (org-string-pad): Add compatibility function `org-string-pad' for `string-pad', introduced in Emacs 28.1. * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather than `string-pad'. Since this is more-or-less just copying string-pad's definition from subr-x.el, I think