Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-13 Thread Ihor Radchenko
Tom Gillespie writes: > Here's the rebased patch. It should apply without issue. Best! Applied. https://git.sr.ht/~bzg/org-contrib/commit/b6712e688b3a54c54b80ab34525d4672ff2a8d7a Marcel, note that your recent patch has been overwritten. Let me know if you have any objections. Also, if you see

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-12 Thread Tom Gillespie
Here's the rebased patch. It should apply without issue. Best! Tom From 5247d2459800f82434f1bc3aeea136c18af7923c Mon Sep 17 00:00:00 2001 From: Tom Gillespie Date: Sun, 4 Dec 2022 01:02:35 -0800 Subject: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats refactor * lisp/org

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-12 Thread Ihor Radchenko
Tom Gillespie writes: > Looks like string-replace doesn't support that notation, > so both too aggressive and without sufficient control. > I've switched to replace-regexp-in-string which does > what we want. > > Here's the updated patch. Thanks! Note that your patch does not apply onto master.

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-11 Thread Tom Gillespie
Date: Sun, 4 Dec 2022 01:02:35 -0800 Subject: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats refactor * lisp/org-expiry.el (org-expiry-insert-created) (org-expiry-insert-expiry): timestamp formats dropped delimiters so a slight modification is required following org commit

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-11 Thread Ihor Radchenko
Tom Gillespie writes: > + (format-time-string > + (string-replace "<" "" > + (string-replace ">" "" (cdr > org-time-stamp-formats) `string-replace' is very aggressive. You may want something like "\\`<" and "\\'>", matching

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-10 Thread Tom Gillespie
mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> From 248104955707a7195a594712d1c7ad9d64dee1c1 Mon Sep 17 00:00:00 2001 From: Tom Gillespie Date: Sun, 4 Dec 2022 01:

Re: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-08 Thread Ihor Radchenko
Tom Gillespie writes: > Hi, >Here is a patch for org-contrib/lisp/org-expiry.el to account for > recent changes to org-time-stamp-formats. Best, > Tom > > PS is this list still the best place to send org-contrib patches? Yes, this list is suitable as long as org-expiry is orphaned. For the

[PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats

2022-12-04 Thread Tom Gillespie
Dec 2022 01:02:35 -0800 Subject: [PATCH] lisp/org-expiry.el: Account for org-time-stamp-formats refactor * lisp/org-expiry.el (org-expiry-insert-created) (org-expiry-insert-expiry): timestamp formats dropped delimiters so a slight modification is required following org commit