Re: [new patch] Re: [PATCH] make org-notify support for macOS desktop notification

On 26/09/2021 15:52, Bastien wrote: stardiviner writes: Here is the new patch which invokes notifications though Emacs built-in API `ns-do-applescript`. Applied in the main branch, thanks. Notice that applied patch has a minor issue: backslashes are not escaped before argument is passed to

Re: [new patch] Re: [PATCH] make org-notify support for macOS desktop notification

Hi, stardiviner writes: > Here is the new patch which invokes notifications though Emacs > built-in API `ns-do-applescript`. Applied in the main branch, thanks. -- Bastien

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

It may eventually be incorporated into the very popular emacs-mac port (railwaycat tap in homebrew); however, it will probably not be incorporated into the nextstep/emacs main code. I started looking at doing a version for the mainline code, but it’s hard to get motivated b/c using that version

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

Hi Chris, thanks for your work. I have a question, will your patch of notification code be merged to upstream? If yes, I think my patch will be not necessary. If no, then I think add a my workaround for macOS is considerable. > On Jul 7, 2021, at 2:23 AM, Christian Hopps wrote: > > It supports

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

It supports imagemagick (specify —with-imagemagick), and it includes svg by default, I simply forked the railwaycat version and added the native notification code. Thanks, Chris. > On Jul 6, 2021, at 11:30 AM, stardiviner wrote: > > Thanks for your suggestion. Does your Emacs build supports i

Re: [new patch] [PATCH] make org-notify support for macOS desktop notification

Thanks for your suggestion. Does your Emacs build supports imagemagick image view and svg feature support? Because company-mode now have built-in icons support. This is the reason that I switch from https://emacsformacosx.com/ to Homebrew cask Emacs version. > On J

Re: [PATCH] make org-notify support for macOS desktop notification

On 06/07/2021 08:45, stardiviner wrote: Here is the new patch which invokes notifications though Emacs built-in API `ns-do-applescript`. I suspect, you considered your original patch as small and simple, didn't you? + (format "display notification \"%s\" with title \"Org mode not

Re: [PATCH] make org-notify support for macOS desktop notification

stardiviner writes: >> On Jul 6, 2021, at 8:06 AM, Tim Cross wrote: >> >> >> stardiviner writes: >> On Jul 5, 2021, at 7:55 PM, Maxim Nikulin wrote: On 05/07/2021 10:50, stardiviner wrote: > I updated the patch, I found the package `osx-lib` contains solution. > So

Re: [new patch] Re: [PATCH] make org-notify support for macOS desktop notification

Hi, Please consider: I added full native notification support to the popular OS X Emacs build available in homebrew. This supports rewrites notifications-notify defun to use the native code rather than dbus, and so everything "Just Works". Info can be found here: https://github.com/choppsv1/

[new patch] Re: [PATCH] make org-notify support for macOS desktop notification

Here is the new patch which invokes notifications though Emacs built-in API `ns-do-applescript`. 0001-org-clock.el-Make-org-notify-support-macOS-notificat.patch Description: Binary data > On Jul 6, 2021, at 8:06 AM, Tim Cross wrote: > > > stardiviner writes: > >>> On Jul 5, 2021, at 7:55

Re: [PATCH] make org-notify support for macOS desktop notification

> On Jul 6, 2021, at 8:06 AM, Tim Cross wrote: > > > stardiviner writes: > >>> On Jul 5, 2021, at 7:55 PM, Maxim Nikulin wrote: >>> >>> On 05/07/2021 10:50, stardiviner wrote: I updated the patch, I found the package `osx-lib` contains solution. So I removed the directly osascri

Re: [PATCH] make org-notify support for macOS desktop notification

stardiviner writes: >> On Jul 5, 2021, at 7:55 PM, Maxim Nikulin wrote: >> >> On 05/07/2021 10:50, stardiviner wrote: >>> I updated the patch, I found the package `osx-lib` contains solution. >>> So I removed the directly osascript process invocation. >> >> I have no objections any more. On

Re: [PATCH] make org-notify support for macOS desktop notification

> On Jul 5, 2021, at 7:55 PM, Maxim Nikulin wrote: > > On 05/07/2021 10:50, stardiviner wrote: >> I updated the patch, I found the package `osx-lib` contains solution. >> So I removed the directly osascript process invocation. > > I have no objections any more. On the other hand I have no acc

Re: [PATCH] make org-notify support for macOS desktop notification

On 05/07/2021 10:50, stardiviner wrote: I updated the patch, I found the package `osx-lib` contains solution. So I removed the directly osascript process invocation. I have no objections any more. On the other hand I have no access to macOS, so I have not tested this patch. Feel free to ignore

Re: [PATCH] make org-notify support for macOS desktop notification

I updated the patch, I found the package `osx-lib` contains solution. So I removed the directly osascript process invocation. 0001-org-clock.el-Make-org-notify-support-macOS-notificat.patch Description: Binary data > On Jul 4, 2021, at 1:48 PM, Maxim Nikulin wrote: > > On 04/07/2021 07:23, s

Re: [PATCH] make org-notify support for macOS desktop notification

On 04/07/2021 07:23, stardiviner wrote: I found `org-notify` does not support macOS desktop notification. So I write a small patch for this. I am surprised that there is no OS-agnostic function in Emacs that sends simple notification, suitable when no advanced feature are necessary. Only OS-

[PATCH] make org-notify support for macOS desktop notification

I found `org-notify` does not support macOS desktop notification. So I write a small patch for this. Thanks for reviewing. 0001-org-clock.el-Make-org-notify-support-macOS-notificat.patch Description: Binary data