Max Nikulin writes:
>> Thanks! Your patch looks cleaner.
>
> In the meanwhile Lars fixed ERT in Emacs-29, so empty string is
> considered as false now, see https://debbugs.gnu.org/53313
> Values like "no" should not be considered as false by Org makefiles, so
> I am attaching an updated
On 21/01/2022 20:33, Ihor Radchenko wrote:
Max Nikulin writes:
I am attaching a tentative patch for Org that should make
EMACS_TEST_VERBOSE setting more transparent.
Thanks! Your patch looks cleaner.
In the meanwhile Lars fixed ERT in Emacs-29, so empty string is
considered as false now,
Max Nikulin writes:
> I am attaching a tentative patch for Org that should make
> EMACS_TEST_VERBOSE setting more transparent.
Thanks! Your patch looks cleaner.
In addition, I am attaching a tentative hack to make ERT pretty-print
the failure reason as you wished. WDYT?
Though it may also be
Max Nikulin writes:
>> Side note. In f0c474e659b81da0d2ab75e7ec109355965f7a1c I have noticed
>> "* H1\nP1\n> that likely should be
>> "* H1\nP1\n* H2\n"
>
> Unrelated to this patch, but still should be fixed.
Thanks! Fixed.
Best,
Ihor
On 02/01/2022 20:12, Ihor Radchenko wrote:
In newer Emacs, ERT is capable of providing more info about FAILED
tests. Maybe we can enable this option by default in the Org test suite?
Thinking more, I have realized that something is wrong.
Behavior of tests in Org should be controlled by
A couple of additional remarks.
On 15/01/2022 19:52, Max Nikulin wrote:
On 02/01/2022 20:12, Ihor Radchenko wrote:
Subject: [PATCH] make test: Make failure results more verbose
At first it was not clear to me that only *summary* of test results is
affected.
Should not the variable
Ihor, I have tried your patch. My opinion is that you can go ahead and
commit it as is. Reaction to my comments is optional.
Subject: [PATCH] make test: Make failure results more verbose
At first it was not clear to me that only *summary* of test results is
affected.
+ifeq
On 07/01/2022 22:04, Ihor Radchenko wrote:
Max Nikulin writes:
Ihor, are there examples of new error reports in mail lists, blogs, etc?
I am not motivated enough to try development version of emacs, but my
impression that current error log looks like rectangles of garbage.
Yeah, I should
Max Nikulin writes:
> Ihor, are there examples of new error reports in mail lists, blogs, etc?
> I am not motivated enough to try development version of emacs, but my
> impression that current error log looks like rectangles of garbage.
Yeah, I should have attached examples to the original
On 02/01/2022 20:12, Ihor Radchenko wrote:
In newer Emacs, ERT is capable of providing more info about FAILED
tests. Maybe we can enable this option by default in the Org test suite?
I like you attempts to make tests better.
Ihor, are there examples of new error reports in mail lists, blogs,
129033.git.yanta...@gmail.com>
From: Ihor Radchenko
Date: Sun, 2 Jan 2022 21:08:11 +0800
Subject: [PATCH] make test: Make failure results more verbose
* mk/default.mk: New option BTEST_ERT_VERBOSE controlling verbosity of
ERT results. The new default is verbose.
* mk/targets.mk (check test t
11 matches
Mail list logo
