[WORG] Document in more detail about what maintainers do? (was: [PATCH] ob-clojure.el: Add support for babashka and nbb backend)

2022-09-27 Thread Ihor Radchenko
Bastien writes: > Replying to emails when we CC you should be enough, but more help is > always welcome, of course. > > Also, please create an account on https://savannah.gnu.org/git/ and > ask to join the Emacs group: https://savannah.gnu.org/git/?group=emacs > > An Emacs maintainer will give

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-27 Thread Bastien
Hi Daniel, thanks for volunteering! I added you as the ob-clojure.el maintainer on the main branch (commit 1c7acb427). Replying to emails when we CC you should be enough, but more help is always welcome, of course. Also, please create an account on https://savannah.gnu.org/git/ and ask to join

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-26 Thread Ihor Radchenko
Daniel Kraus writes: >> Would you consider taking over the maintainance of ob-clojure.el? > > I think I would. What does this exactly entail? > Should I subscribe to https://updates.orgmode.org/ or something? We have some info in https://orgmode.org/worg/org-maintenance.html#org37c7d5d

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-26 Thread Daniel Kraus
Hi! Bastien writes: > Applied in main as 764642f5, thanks a lot and sorry for the delay. > > I also added you to https://orgmode.org/worg/contributors.html. Thank you very much :) > Would you consider taking over the maintainance of ob-clojure.el? I think I would. What does this exactly

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-25 Thread Bastien
Hi Christopher, "Christopher M. Miles" writes: > Thanks, Bastien. (I know you sent a patch and I'll review it, no worry!) >> Would you consider taking over the maintainance of ob-clojure.el? > > Thanks for invitation, I already maintained many org-mode related > libraries. Even though clojure

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-25 Thread Christopher M. Miles
Bastien writes: > Hi Daniel, > > Daniel Kraus writes: > >> Attached is the patch changed the logic to use a temp file with >> org-babel-eval. > > Applied in main as 764642f5, thanks a lot and sorry for the delay. > > I also added you to https://orgmode.org/worg/contributors.html. > > Would you

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-25 Thread Christopher M. Miles
Bastien writes: > Hi Daniel, > > Daniel Kraus writes: > >> Attached is the patch changed the logic to use a temp file with >> org-babel-eval. > > Applied in main as 764642f5, thanks a lot and sorry for the delay. > > I also added you to https://orgmode.org/worg/contributors.html. > Thanks,

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-09-24 Thread Bastien
Hi Daniel, Daniel Kraus writes: > Attached is the patch changed the logic to use a temp file with > org-babel-eval. Applied in main as 764642f5, thanks a lot and sorry for the delay. I also added you to https://orgmode.org/worg/contributors.html. Would you consider taking over the

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-06-11 Thread Ihor Radchenko
Daniel Kraus writes: > just wanted to bump this thread and ask if I can do anything > to move this forward? > I'm using it since a few month and works for me. Sorry for the late reply. I am not familiar at all with clojure, so it is hard for me to test the patch. It would help if you also

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-02-02 Thread Max Nikulin
On 31/01/2022 14:58, Daniel Kraus wrote: just wanted to bump this thread and ask if I can do anything to move this forward? Your patch is tracked at https://updates.orgmode.org/ , so do not worry too much (look at the list of pending patches). Bunch of commits may happen before next major

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2022-01-31 Thread Daniel Kraus
ate: Sat, 13 Nov 2021 22:51:56 +0100 > Subject: [PATCH] ob-clojure.el: Add support for babashka and nbb backend > > * lisp/ob-clojure.el: Add support for babashka and nbb backend. > --- > [...]

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-12-22 Thread Daniel Kraus
Daniel Kraus writes: > I filled out the copyright assignment and waiting for them. > I'll mail again when it's done. Just want to mention that I finally received my signed of the copyright agreement. so there is no blocker from this site in case it doesn't count as tinychange. Thanks,

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-20 Thread Daniel Kraus
Max Nikulin writes: > Thank you for contribution. I do not have strong objection any more. I am not > familiar with babel internals, so I leave further discussion to maintainers. > > If you have not signed copyright assignment yet, likely you should do it to > proceed (I am unsure concerning

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-17 Thread Max Nikulin
On 15/11/2021 23:05, Daniel Kraus wrote: Max Nikulin writes: Attached is the patch changed the logic to use a temp file with org-babel-eval. Thank you for contribution. I do not have strong objection any more. I am not familiar with babel internals, so I leave further discussion to

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-15 Thread Daniel Kraus
ov 2021 22:51:56 +0100 Subject: [PATCH] ob-clojure.el: Add support for babashka and nbb backend * lisp/ob-clojure.el: Add support for babashka and nbb backend. --- lisp/ob-clojure.el | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lisp/ob-clojure.el b/lisp/ob-clojur

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-15 Thread Max Nikulin
On 14/11/2021 23:30, Daniel Kraus wrote: Max Nikulin writes: On 14/11/2021 22:28, Daniel Kraus wrote: +(defun ob-clojure-escape-quotes (str-val) + "Escape quotes for STR-VAL." + (replace-regexp-in-string "\"" "\\\"" str-val 'FIXEDCASE 'LITERAL)) + +(defun ob-clojure-eval-with-babashka (bb

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-14 Thread Daniel Kraus
Hi! Max Nikulin writes: > On 14/11/2021 22:28, Daniel Kraus wrote: >> +(defun ob-clojure-escape-quotes (str-val) >> + "Escape quotes for STR-VAL." >> + (replace-regexp-in-string "\"" "\\\"" str-val 'FIXEDCASE 'LITERAL)) >> + >> +(defun ob-clojure-eval-with-babashka (bb expanded) >> +

Re: [PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-14 Thread Max Nikulin
On 14/11/2021 22:28, Daniel Kraus wrote: * lisp/ob-clojure.el: Add support for babashka and nbb backend. --- +(defun ob-clojure-escape-quotes (str-val) + "Escape quotes for STR-VAL." + (replace-regexp-in-string "\"" "\\\"" str-val 'FIXEDCASE 'LITERAL)) + +(defun ob-clojure-eval-with-babashka

[PATCH] ob-clojure.el: Add support for babashka and nbb backend

2021-11-14 Thread Daniel Kraus
* lisp/ob-clojure.el: Add support for babashka and nbb backend. --- This adds support to ob-clojure for babashka (https://github.com/babashka/babashka) and nbb (node version of babashka). It doesn't use `params` as I'm not really sure what they're used for and if they're important for evaluation.