* lisp/ob-sql.el (org-babel-execute:sql, org-babel-sql-dbstring-saphana):
Add basic support for SAP HANA to SQL blocks
* testing/lisp/test-ob-sql.el: Basic tests for generated db connection
string
This change adds basic support for SAP HANA to SQL blocks by
specifying saphana as :engine.
It also
* lisp/ob-sql.el (org-babel-execute:sql, org-babel-sql-dbstring-saphana):
Add basic support for SAP HANA to SQL blocks
* testing/lisp/test-ob-sql.el: Basic tests for generated db connection
string
This change adds basic support for SAP HANA to SQL blocks by
specifying saphana as :engine.
It also
* lisp/ob-sql.el (org-babel-execute:sql, org-babel-sql-dbstring-saphana):
Add basic support for SAP HANA to SQL blocks
* testing/lisp/test-ob-sql.el: Basic tests for generated db connection
string
This change adds basic support for SAP HANA to SQL blocks by
specifying saphana as :engine.
It also
Hi,
could someone please let me know if something is missing/incorrect?
If everything should be fine, is there anything still required from my side
to include this patch? I couldn't find anything else in the contributor
guide.
Thanks and best regards,
Robin
On Thu, 4 Feb 2021 at 08:55, Robin Cam
Robin Campbell Joy writes:
> Hi,
>
> could someone please let me know if something is missing/incorrect?
Thanks for the patch, and sorry for the delay.
> On Thu, 4 Feb 2021 at 08:55, Robin Campbell Joy wrote:
>
>> * lisp/ob-sql.el (org-babel-execute:sql, org-babel-sql-dbstring-saphana):
>> Add
Hi,
thank you very much for you feedback.
Kyle Meyer wrote:
>> This patch is large enough that copyright should be assigned to the FSF.
>> Assuming you haven't already, are you willing to complete the copyright
>> paperwork?
I did this before sending the patch.
>> It looks like many of the li
Hello Robin,
from this patch I infer that you work with SAP. Can I bug you off-list
with a few questions unrelated to org-mode but related to
programmatically interact with SAP?
Thank you.
Best,
Dan
On 04/02/2021 08:55, Robin Campbell Joy wrote:
> * lisp/ob-sql.el (org-babel-execute:sql, org-ba
Robin Campbell Joy writes:
> Subject: [PATCH] ob-sql.el: Add support for SAP HANA
Thanks for the update. Pushed (b241c126b).
> diff --git a/testing/lisp/test-ob-sql.el b/testing/lisp/test-ob-sql.el
[...]
> +
> +(require 'org-test)
> +(require 'ob-sql)
I've dro
