Re: [PATCH] ol.el: Always prompt for description in `org-insert-link'

2022-09-17 Thread Ihor Radchenko
Bastien Guerry writes: >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=69b36beac790bad95fdd9ce4a7bcfbbb46d39c64 >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d8d7fba61652434764c9906df69db373ff4f7f6 > > Are these changes the commits I should start from? If

Re: [PATCH] ol.el: Always prompt for description in `org-insert-link'

2022-09-17 Thread Bastien Guerry
Ihor Radchenko writes: > Could you please check the ongoing changes in this area > (storing/inserting links)? The code in this area is old, confusing, and > not fully documented. I'm afraid that we may break something in the > process of refactoring. If you see some dangerous changes, please let

Re: [PATCH] ol.el: Always prompt for description in `org-insert-link'

2022-09-15 Thread Ihor Radchenko
Max Nikulin writes: > I have an idea how to fix the code to bypass the description prompt if > path is completed by description discarding identical path and > description, but I prefer to drop the confusing variable and not depend > on the means how the link was selected from the list of stor

[PATCH] ol.el: Always prompt for description in `org-insert-link'

2022-09-14 Thread Max Nikulin
Hi, The `org-insert-link' function has the `auto-desc' variable to suppress user prompt for link description. It worked accordingly its intention (as I understand it) a couple of months a decade ago, after that the logic was broken. Actually the behavior is rather strange: users may edit desc