Re: [PATCH] org-agenda: Skip formatting if format string is ""

2022-03-21 Thread Ihor Radchenko
Samim Pezeshki writes: > Is there anything I need to do for this to be merged? Applied. I took a freedom to push your patch to bugfix amending the indentation changes. (847e33230) Note that your total contribution to Org is approaching 15 LOC - a legal threshold for insignificant changes. If y

Re: [PATCH] org-agenda: Skip formatting if format string is ""

2022-03-15 Thread Samim Pezeshki
Hi! Is there anything I need to do for this to be merged? Thanks On Wed, Feb 9, 2022 at 10:44 PM Samim Pezeshki wrote: > Thanks Ihor for the detailed explanation, > I updated the patch as you suggested. > > On Sun, Feb 6, 2022 at 12:53 PM Ihor Radchenko wrote: > >> Samim Pezeshki writes: >>

Re: [PATCH] org-agenda: Skip formatting if format string is ""

2022-02-09 Thread Samim Pezeshki
Thanks Ihor for the detailed explanation, I updated the patch as you suggested. On Sun, Feb 6, 2022 at 12:53 PM Ihor Radchenko wrote: > Samim Pezeshki writes: > > > This commit prevents having extra spaces when the TODO format string is > an > > empty string (""). It was not working properly,

Re: [PATCH] org-agenda: Skip formatting if format string is ""

2022-02-06 Thread Ihor Radchenko
Samim Pezeshki writes: > This commit prevents having extra spaces when the TODO format string is an > empty string (""). It was not working properly, with this patch now it > works correctly. Thanks for the patch! > (concat > (substring x 0 (match-end 1)) > ...

[PATCH] org-agenda: Skip formatting if format string is ""

2022-02-05 Thread Samim Pezeshki
Hi! I had contributed a patch which was merged at commit 90a9ee17410a4b6663f5957c653258e9f9418d7d . This commit prevents having extra spaces when the TODO format string is an empty string (""). It was not working properly, with this patch now it works correctly. Attached is the screenshot of th

Re: [PATCH] org-agenda: Skip formatting if format string is ""

2021-05-15 Thread Bastien
Hi Samim, Samim Pezeshki writes: > This is my first patch. Thank you! > The patch skips formatting TODO item in org-agenda when the format > string is "".  > When the format string was "" the extra space would still be inserted > which was not needed when there is no TODO keyword. Applied in

[PATCH] org-agenda: Skip formatting if format string is ""

2021-05-08 Thread Samim Pezeshki
a5f277024f8b55cc Mon Sep 17 00:00:00 2001 From: Samim Pezeshki Date: Sat, 8 May 2021 20:09:16 +0430 Subject: [PATCH] org-agenda: Skip formatting if format string is "" When the format string was "" the extra space would still be inserted which was not needed when there is no TO