Re: [PATCH] org-capture.el: Allow `(here)' as a template target

On Fri, Jun 23, 2023 at 6:53 AM Ihor Radchenko wrote: > Tim Visher writes: > > > I've attached a small follow up `worg` patch to hopefully clarify the > > changelog section of the commit message going forward for other > > contributors. > > Thanks! > Applied, onto master, with amendments: > > 1.

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

Tim Visher writes: > I've attached a small follow up `worg` patch to hopefully clarify the > changelog section of the commit message going forward for other > contributors. Thanks! Applied, onto master, with amendments: 1. I removed "Note", converting into normal sentence. Note is redundant. 2.

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

On Thu, Jun 22, 2023 at 6:13 AM Ihor Radchenko wrote: > Tim Visher writes: > > > Will do! I've attached a prospective patch file but I'm not sure I follow > > what you mean by 'add all the necessary changelog entries to the final > > commit > > message'. Looking at this commit > > < > https://gi

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

Tim Visher writes: > Will do! I've attached a prospective patch file but I'm not sure I follow > what you mean by 'add all the necessary changelog entries to the final > commit > message'. Looking at this commit >

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

On Wed, Jun 21, 2023 at 11:54 AM Ihor Radchenko wrote: > Tim Visher writes: > > >> Also, may you update the docstring of `org-capture-templates' > > > > > > Good catch! This has been done in patch 0004 now. Look good? > > Yup. > 👍 >> "10.1.3.1 Template elements" section of Org manual? > > > >

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

Tim Visher writes: >> Also, may you update the docstring of `org-capture-templates' > > > Good catch! This has been done in patch 0004 now. Look good? Yup. >> "10.1.3.1 Template elements" section of Org manual? > > I'm confused about what you're referring to here. Isn't that what 0002 does? Ye

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

On Wed, Jun 21, 2023 at 6:29 AM Ihor Radchenko wrote: > Tim Visher writes: > > > I've now created patches for updating the manual and NEWS file. Let me > know > > how they look! > > Thanks! The patches look good, and the commit messages look excellent. > ٩( ᐛ )و > You could, however, squash t

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

Tim Visher writes: > Sorry this took me forever to get to. > > I've now created patches for updating the manual and NEWS file. Let me know > how they look! Thanks! The patches look good, and the commit messages look excellent. You could, however, squash the patches together - they are about the

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

On Fri, May 12, 2023 at 12:32 PM Ihor Radchenko wrote: > Tim Visher writes: > > > I think this should likely involve an update to the manual but I don't > want > > to bother doing that unless the basic approach is approved. > > LGTM. > Sorry this took me forever to get to. I've now created pat

Re: [PATCH] org-capture.el: Allow `(here)' as a template target

Tim Visher writes: > I think this should likely involve an update to the manual but I don't want > to bother doing that unless the basic approach is approved. LGTM. We might also fix on the other side, not demanding (`car-safe') the target to be a list. -- Ihor Radchenko // yantar92, Org mode

[PATCH] org-capture.el: Allow `(here)' as a template target

Subject: [PATCH] org-capture.el: Allow `(here)' as a template target * lisp/org-capture.el (org-capture-set-target-location): Allow `(here)' as a template target in addition to `here'. Templates had no user accessible way to target the current location directly from a capture template.