Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-15 Thread Christopher M. Miles
No objection -- [ stardiviner ] I try to make every word tell the meaning that I want to express without misunderstanding. Blog: https://stardiviner.github.io/ IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 signature.asc

Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-15 Thread Ihor Radchenko
Ihor Radchenko writes: > I'd like to propose applying initial visibility to the freshly decrypted > headings. IMHO, it makes much more sense by default compared to showing > all the text unfolded, including property drawers. > > Any objections? Applied, onto main.

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: > I'm under macOS system. the result of (getenv "DISPLAY") is > "ssh-askpass". This is weird... I also have (setenv "SSH_ASKPASS" "ssh-askpass-fullscreen") in my config. Maybe you are setting similar things in bashrc or init.el. -- Ihor Radchenko // yantar92,

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> The current CPU report indeed not contains heavy org-crypt. Because my >> epa get problem. When I edit a GnuPG encrypted "encrypt.org.gpg", it >> suspend on epa waiting for process to finished. It never ends unless I >> press [C-g]

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: > The current CPU report indeed not contains heavy org-crypt. Because my > epa get problem. When I edit a GnuPG encrypted "encrypt.org.gpg", it > suspend on epa waiting for process to finished. It never ends unless I > press [C-g] to quit it. Which looks like gpg

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > > May you elaborate what performance issues you are experiencing? My performance issue is a large Org file about 2M size on saving. I will reproduce and generate profiler report for more detailed data and update

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: May you elaborate what performance issues you are experiencing? >>> >>> My performance issue is a large Org file about 2M size on saving. I will >>> reproduce and generate profiler report for more detailed data and update >>> in this thread. >> >> Please save

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> We should certainly not attempt decryption on by default - it may >>> be annoying when you actually do not want to decrypt anything, just >>> look inside. >> >> You're right, I have not consider enough. > > Of course, you can still

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: >> We should certainly not attempt decryption on by default - it may >> be annoying when you actually do not want to decrypt anything, just >> look inside. > > You're right, I have not consider enough. Of course, you can still use `org-cycle-hook' if you want

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> I'm also try to improve this file to improve large Org buffer saving >> performance. > > org-encrypt already caches the encrypted text and takes basically no > time for the repeated encryption, as long the text to be encrypted is >

Re: [SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-05-01 Thread Ihor Radchenko
"Christopher M. Miles" writes: > I'm also try to improve this file to improve large Org buffer saving > performance. org-encrypt already caches the encrypted text and takes basically no time for the repeated encryption, as long the text to be encrypted is unchanged. > I have some ideas: > > -

[SUGGESTION] Re: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-04-30 Thread Christopher M. Miles
Thanks Ihor for improve this file. I'm also try to improve this file to improve large Org buffer saving performance. I have some ideas: - auto encrypt buffer on buffer save hook (currently mechanism, your patch improved it) - auto decrypt on org-cycle expand headline if current headline is

[PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption

2023-04-30 Thread Ihor Radchenko
age-Id: <5f90460cf565e9c3185f58a631500207e9b14d39.1682886052.git.yanta...@posteo.net> From: Ihor Radchenko Date: Sun, 30 Apr 2023 22:15:11 +0200 Subject: [PATCH] org-crypt-decrypt-entry: Apply initial visibility upon decryption * lisp/org-crypt.el: Call `org-cycle-set-startup-v