Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Bastien Guerry writes: > Ihor Radchenko writes: > >> Bastien, may you please confirm Roshan's copyright status? > > Yes, I do confirm Roshan is a FSF registered contributor for Emacs. Updated our records. https://git.sr.ht/~bzg/worg/commit/9015a8ea -- Ihor Radchenko // yantar92, Org mode

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Ihor Radchenko writes: > Bastien, may you please confirm Roshan's copyright status? Yes, I do confirm Roshan is a FSF registered contributor for Emacs. -- Bastien Guerry

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Roshan Shariff writes: > For the future, I wanted to clarify that I do have a copyright > assignment to the FSF "for the suite of programs known as GNU EMACS". > I have a signed copy of the assignment form dated 3 April, 2022. I > should be in the list as "Roshan Shariff", but if not I can

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Thanks again Ihor! For the future, I wanted to clarify that I do have a copyright assignment to the FSF "for the suite of programs known as GNU EMACS". I have a signed copy of the assignment form dated 3 April, 2022. I should be in the list as "Roshan Shariff", but if not I can follow up with the

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Roshan Shariff writes: > Thanks for the feedback! I'm attaching a new version of the patch that > improves the commit message and avoids the use of file-name-concat. Thanks! Applied, onto main, with minor amendments. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=4ea9a98f8 I

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Hi Ihor, On Sat, 5 Aug 2023 at 04:23, Ihor Radchenko wrote: > First, minor one: please put two spaces between sentences in the commit > message. It is our convention. > `file-name-concat' is only available since Emacs 28. > Please use `org-file-name-concat'. Thanks for the feedback! I'm

Re: [PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

Roshan Shariff writes: > * org-macs.el (org-compile-file, org-compile-file-commands): Avoid > converting the source path to be relative to the default-directory, > which breaks for absolute source paths when the current directory is a > symlink. > > Commit 5a8a1d4ff [1] changed org-compile-file

[PATCH] org-macs: Fix incorrect use of relative paths in org-compile-file

* org-macs.el (org-compile-file, org-compile-file-commands): Avoid converting the source path to be relative to the default-directory, which breaks for absolute source paths when the current directory is a symlink. Commit 5a8a1d4ff [1] changed org-compile-file to use `file-relative-name` for the