Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Ihor Radchenko writes: > I finally managed to fix the tests. Thank you! I have had this on my to-do list since you brought it up,but I could not find the time to fix it. Rudy -- "'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if it were so, it would be; but as it

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Ihor Radchenko writes: > Ihor Radchenko writes: > >>> All right, I added the 'require' to both files. Better? >> >> Thanks! >> Applied, onto bugfix. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=99c8ed09f > > The tests are failing on older Emacs. >

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Ihor Radchenko writes: >> All right, I added the 'require' to both files. Better? > > Thanks! > Applied, onto bugfix. > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=99c8ed09f The tests are failing on older Emacs. https://builds.sr.ht/~bzg/job/942040

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Rudolf Adamkovič writes: > All right, I added the 'require' to both files. Better? Thanks! Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=99c8ed09f -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

on Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Mon, 6 Feb 2023 22:33:40 +0100 Subject: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code * lisp/ox-texinfo.el (org-texinfo-supports-math-p): Fix the incorrect syntax @displaymath{1 + 1 = 2} used to

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

On 07/02/2023 19:21, Ihor Radchenko wrote: Max Nikulin writes: Historically subr-x was avoided in Org. Latest discussion: https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce...@gmail.com/T/#u ... which concluded that it is safe to use subr-x. If we need to add a require, so be it. I

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Max Nikulin writes: > In emacs-26 `string-join' is defined in subr-x.el, but ox-texinfo.el > does not have (require 'subr-x). Personally I see nothing bad in > > (format "@displaymath\n%s\n@end" math-example) > > Historically subr-x was avoided in Org. Latest discussion: >

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

Rudolf, I am afraid there is another obstacle till your step to improve Org may be completed. On 07/02/2023 15:39, Rudolf Adamkovič wrote: -(let* ((input-file -(make-temp-file "test" nil ".info")) - (input-content -(concat

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

>From ce1062dbda870346b18ae35c28e9cc034c0de548 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Mon, 6 Feb 2023 22:33:40 +0100 Subject: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code * lisp/ox-texinfo.el (org-texinfo-supports-math-p): Fix the incorre

Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

On 07/02/2023 04:42, Rudolf Adamkovič wrote: --- a/lisp/ox-texinfo.el +++ b/lisp/ox-texinfo.el @@ -2030,7 +2030,7 @@ Once computed, the results remain cached." (input-content (concat (format "@setfilename %s" input-file) "\n"

[PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code

* lisp/ox-texinfo.el (org-texinfo-supports-math-p): Fix the incorrect syntax @displaymath{1 + 1 = 2} used to detect whether Texinfo supports TeX "math mode". Instead, use the correct syntax @math{1 + 1 = 2}. --- lisp/ox-texinfo.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git