On Mon, Jan 23 2023, Ihor Radchenko wrote:
> Ihor Radchenko writes:
>
>> Ihor Radchenko writes:
>>
>>> So, the test failure is real.
>>
>> The error buffer contents when the test fails is the following:
>>
>> warning: using the gnuplot graphics toolkit is discouraged
>> ...
>> [ Babel evaluatio
Ihor Radchenko writes:
> Ihor Radchenko writes:
>
>> So, the test failure is real.
>
> The error buffer contents when the test fails is the following:
>
> warning: using the gnuplot graphics toolkit is discouraged
> ...
> [ Babel evaluation exited with code 0 ]
>
> Exit code is 0, so octave does
On 14/01/2023 20:04, Leo Butler wrote:
line 0: warning: iconv failed to convert degree sign
This warning makes no sense to me.
Just a guess. Some code creates a plot with the "°" character, but
worker locale is ASCII, not UTF-8 (en_US.UTF-8, C.UTF-8, etc.)
Leo Butler writes:
>> The gnuplot graphics toolkit is not actively maintained and has a number
>> of limitations that are unlikely to be fixed. Communication with gnuplot
>> uses a one-directional pipe and limited information is passed back to the
>> Octave interpreter so most changes made inter
On Fri, Jan 13 2023, Ihor Radchenko wrote:
> Ihor Radchenko writes:
>
>> So, the test failure is real.
>
> The error buffer contents when the test fails is the following:
>
> warning: using the gnuplot graphics toolkit is discouraged
>
> The gnuplot graphics toolkit is not actively maintained an
Ihor Radchenko writes:
> So, the test failure is real.
The error buffer contents when the test fails is the following:
warning: using the gnuplot graphics toolkit is discouraged
The gnuplot graphics toolkit is not actively maintained and has a number
of limitations that are unlikely to be fixe
Leo Butler writes:
>> So, the test failure is real.
>>
>> https://orgmode.org/list/94980226-d29a-4969-8640-1143a1979...@bundesbrandschatzamt.de
>> might be related.
>
> Ihor,
>
> How do you want to treat the patch that was included? I think we should
> have something like that to catch errors lik
On Wed, Jan 11 2023, Ihor Radchenko wrote:
> Leo Butler writes:
>
>> Leo, could you please take a look?
>
> An earlier test is creating that *Org Babel Error Output* buffer.
>>>
>>> I will try to look into improving the tests so that we can trap the test(s)
>>> that is(are) creating
Leo Butler writes:
> Leo, could you please take a look?
An earlier test is creating that *Org Babel Error Output* buffer.
>>
>> I will try to look into improving the tests so that we can trap the test(s)
>> that is(are) creating that error buffer.
>
> See the attachment. There are f
On Sat, Jan 07 2023, Leo Butler wrote:
> On Fri, Jan 06 2023, Ihor Radchenko wrote:
>
>>
>> Leo Butler writes:
>>
https://builds.sr.ht/~bzg/job/914954
2 unexpected results:
FAILED ob-octave/graphics-file ((should-not (get-buffer "*Org-Babel
Error Output*")) :form (ge
Ihor Radchenko writes:
>> See the attached patch.
>
> Thanks!
> Installed onto bugfix.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41ebc2e40
And still not enough...
Though this time it does not look like our fault:
https://builds.sr.ht/~bzg/job/918602
3 unexpected results:
On Fri, Jan 06 2023, Ihor Radchenko wrote:
>
> Caution: This message was sent from outside the University of Manitoba.
>
>
> Leo Butler writes:
>
>>> Apparently, `sleep-for' 1 second
Leo Butler writes:
>> Apparently, `sleep-for' 1 second was not enough, and I decided to remove
>> checking file size completely.
>
> Hello Ihor,
>
> Is there an environment variable that could be used to determine is the
> tests are being run on sourcehut? This would let us cut out that test on
>
On Mon, Jan 02 2023, Ihor Radchenko wrote:
> Ihor Radchenko writes:
>
>> Ihor Radchenko writes:
>>
There is a race condition between writing the contents of the graphics
file to disk and emacs checking the file size. My guess is that this is
causing the problem (and that the same
Ihor Radchenko writes:
> Ihor Radchenko writes:
>
>>> There is a race condition between writing the contents of the graphics
>>> file to disk and emacs checking the file size. My guess is that this is
>>> causing the problem (and that the same failure applies for emacs-2{6,7},
>>> since only the
Ihor Radchenko writes:
>> There is a race condition between writing the contents of the graphics
>> file to disk and emacs checking the file size. My guess is that this is
>> causing the problem (and that the same failure applies for emacs-2{6,7},
>> since only the emacs-28 reports the exact test
Leo Butler writes:
>> Note that the tests are failing only partially. The graphics file does
>> get created, but it has 0 size for some reason. Maybe something to do
>> with non-graphical CI environment.
>
> There is a race condition between writing the contents of the graphics
> file to disk and
On Wed, Dec 21 2022, Ihor Radchenko wrote:
> Ihor Radchenko writes:
>
>>> Upon confirming the FSF copyright assignment, I have applied the patch
>>> onto bugfix.
>>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=01c0ebee2
>>
>> Your patch appears to not work in some environment
Ihor Radchenko writes:
>> Upon confirming the FSF copyright assignment, I have applied the patch
>> onto bugfix.
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=01c0ebee2
>
> Your patch appears to not work in some environments:
>
> https://builds.sr.ht/~bzg/job/906710
>
> Any i
Ihor Radchenko writes:
> Leo Butler writes:
>
>> From 386c9c2f65730459bdc69b2e0b0b76e22e32dbc9 Mon Sep 17 00:00:00 2001
>> From: Leo Butler
>> Date: Tue, 8 Nov 2022 13:31:47 -0600
>> Subject: [PATCH] prevent error in Octave process, add tests, update test docs
>
> Upon confirming the FSF copyri
Leo Butler writes:
> From 386c9c2f65730459bdc69b2e0b0b76e22e32dbc9 Mon Sep 17 00:00:00 2001
> From: Leo Butler
> Date: Tue, 8 Nov 2022 13:31:47 -0600
> Subject: [PATCH] prevent error in Octave process, add tests, update test docs
Upon confirming the FSF copyright assignment, I have applied the
On Mon, Nov 14 2022, Ihor Radchenko wrote:
> Leo Butler writes:
>
>> The amended patch is attached. Thanks for your helpful feedback.
>
> Thanks for the patch!
> It looks good, and the tests are passing. However, there is a side effect
> leaving testing/examples/octave-workspace file after runni
Leo Butler writes:
> The amended patch is attached. Thanks for your helpful feedback.
Thanks for the patch!
It looks good, and the tests are passing. However, there is a side effect
leaving testing/examples/octave-workspace file after running the tests.
Can something be done about this?
--
Ih
Ihor, see below.
On Wed, Nov 09 2022, Ihor Radchenko wrote:
> Leo Butler writes:
>
>> Ihor,
>> Thanks for your feeback and the pointer. I have revised the tests and
>> attach the revised patch.
>
> Thanks!
>
> Note that your patch is over 15LOC, which exceeds legally allowed
> contribution size
Leo Butler writes:
> Ihor,
> Thanks for your feeback and the pointer. I have revised the tests and
> attach the revised patch.
Thanks!
Note that your patch is over 15LOC, which exceeds legally allowed
contribution size for people without copyright assignment.
Would you be interested to sign th
On Tue, Nov 08 2022, Ihor Radchenko wrote:
> Leo Butler writes:
>
>> However, I would like feedback/suggestions on writing such a
>> test. Issues include:
>>
>> 1. how to clean up the side-effects, including changes in the test
>>buffer, filesystem and potentially creating an error buffer;
>
Leo Butler writes:
> However, I would like feedback/suggestions on writing such a
> test. Issues include:
>
> 1. how to clean up the side-effects, including changes in the test
>buffer, filesystem and potentially creating an error buffer;
As you did, we generally use unwind-protect. Also, we
Hello,
I am patching a bug in ob-octave.el (see attachment) involving the
creation of graphics files. The bug itself is easy to fix: a single line
in ob-octave.el ensures the special variable `ans' is bound, to prevent
Octave from exiting with a non-zero exit code.
However, I would like feedback/
28 matches
Mail list logo
