Ilya Chernyshov writes:
> Yeah, now it works as it should. Thanks. I've made some minor changes
> I've described in the attached patch.
Thanks!
I squashed all the patches modifying the new test library into a single
commit and changed the duplicate in test-org/file-contents to achieve
its
Ihor Radchenko writes:
> Note that your
> `test-org-tests/test-duplicates-detector-testing-find-duplicates' does
> not look right. I had to adjust the `equal' condition in order to make
> it pass. May you please check if the return value of
> `test-duplicates-detector--find-duplicates' is what
Ilya Chernyshov writes:
> Ihor Radchenko writes:
>
>> What about the attached amendment?
>> It should simplify things significantly.
>
> Sorry, in my previous patch the test that checks the detector itself was not
> even run in 'make test' because of incorrect test prefix.
>
> Your patch does
Ihor Radchenko writes:
> What about the attached amendment?
> It should simplify things significantly.
Sorry, in my previous patch the test that checks the detector itself was not
even run in 'make test' because of incorrect test prefix.
Your patch does not work as you expect. Could you please
Ilya Chernyshov writes:
> Ihor Radchenko writes:
>
>> It has been a while since the last update in this thread.
>> Ilya, do you need any help with the patch?
>
> Hi, here is the updated patch.
Thanks!
What about the attached amendment?
It should simplify things significantly.
>From
Ihor Radchenko writes:
> It has been a while since the last update in this thread.
> Ilya, do you need any help with the patch?
Hi, here is the updated patch.
>From 2385ba08a89f2966a6d71f92e8693e7def33e3fe Mon Sep 17 00:00:00 2001
From: Ilya Chernyshov
Date: Mon, 22 Jan 2024 01:33:56 +0600
Ilya Chernyshov writes:
> There's a lot of tests to change before merging. I'll handle them and
> submit a new patch if you have no questions about the code.
It has been a while since the last update in this thread.
Ilya, do you need any help with the patch?
--
Ihor Radchenko // yantar92,
Org
Ilya Chernyshov writes:
> Sure, here it is. In the patch, I added a new file
> (testing/lisp/test-deduplicator.el) with a test that checks for
> duplicate forms (not just should, should-not, should-error macros) in
> all test files.
It also makes sense to add a test that searches for completely
Ihor Radchenko writes:
> I saw you using your function to detect the existing duplicate tests.
> However, it would also be nice to add it as a test of its own to detect
> duplicates in future. WDYT?
Sure, here it is. In the patch, I added a new file
(testing/lisp/test-deduplicator.el) with a
Ihor Radchenko writes:
> Ilya Chernyshov writes:
>
>> Thank you! If a function that checks for duplicate tests is a welcome
>> addition to org tests, I'll send is as a patch. What do you think?
>
> It would be great. Thanks in advance!
I saw you using your function to detect the existing
Ilya Chernyshov writes:
> Thank you! If a function that checks for duplicate tests is a welcome
> addition to org tests, I'll send is as a patch. What do you think?
It would be great. Thanks in advance!
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at
Ihor Radchenko writes:
> I have re-introduced the new tests in place of the removed ones,
> according to my and Max's findings. On top of the patch.
>
> Applied, onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fe85d61a9
>
Ihor Radchenko writes:
> It looks like the real test is supposed to be
>
> (equal " foo "
> ...
> (org-table-get-field 2 " foo ")
> (buffer-string)
> ...
I have re-introduced the new tests in place of the removed ones,
according to my and Max's findings. On top of the patch.
Applied, onto
Max Nikulin writes:
> The idea to find duplicated tests is bright. The code may be transformed
> in a dedicated unit test. I would not drop existing tests blindly though.
Very good idea indeed.
One gotcha is that not every should form is next level after
ert-deftest. And there are also
On 13/07/2023 02:22, Ilya Chernyshov wrote:
+++ b/testing/lisp/test-ol.el
@@ -301,14 +301,6 @@ Seehttps://github.com/yantar92/org/issues/4.;
(let ((file (buffer-file-name)))
(equal (format "[[file:%s::two]]" file file)
(org-store-link nil))
- (should
-
Ilya Chernyshov writes:
> In my last patch, I found a duplicate test, so I decided to find all of
> the duplicate tests inside testing/lisp/ folder via this function:
Thanks!
> --- a/testing/lisp/test-org-table.el
> +++ b/testing/lisp/test-org-table.el
> @@ -3368,10 +3368,6 @@ See also
me of them.
Here is the patch I wrote:
>From 21ba128bd648c6737ed088abdd2a1824cfe01759 Mon Sep 17 00:00:00 2001
From: Ilya Chernyshov
Date: Thu, 13 Jul 2023 01:36:33 +0700
Subject: [PATCH] testing: Delete duplicate tests
* testing/lisp/test-ol.el (test-org-link/store-link): Delete a duplica
17 matches
Mail list logo
