Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

No worries!! Have a good day :) On October 30, 2022 11:02:18 PM PDT, Ihor Radchenko wrote: >Ihor Radchenko writes: > >>> Good catch! I will submit a v3 patch. >> >> Did you have a chance to work on the patch? > >Oops. I missed that you did and I even merged it. :facepalm: >Sorry for the noise.

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

Ihor Radchenko writes: >> Good catch! I will submit a v3 patch. > > Did you have a chance to work on the patch? Oops. I missed that you did and I even merged it. :facepalm: Sorry for the noise. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

Joseph Turner writes: > Ihor Radchenko writes: > >> Let's take this opportunity and fix another omission in ob-plantuml. >> :results may generally contain Elisp sexps to be evaluated and the whole >> split-string busyness is not accurate. Please use :result-params list >> instead of :results. >

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

Joseph Turner writes: > Ihor Radchenko writes: > >> Let's take this opportunity and fix another omission in ob-plantuml. >> :results may generally contain Elisp sexps to be evaluated and the whole >> split-string busyness is not accurate. Please use :result-params list >> instead of :results. >

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

Ihor Radchenko writes: > Let's take this opportunity and fix another omission in ob-plantuml. > :results may generally contain Elisp sexps to be evaluated and the whole > split-string busyness is not accurate. Please use :result-params list > instead of :results. Good catch! I will submit a v3 p

Re: [PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

Joseph Turner writes: > When :results header arg is set to a value that doesn't include > "file", insert txt output in buffer below src block. This looks reasonable. Thanks! > - (let* ((out-file (or (cdr (assq :file params)) > -(error "PlantUML requires a \":file\" header a

[PATCH v2] lisp/ob-plantuml.el: Insert results in buffer

When :results header arg is set to a value that doesn't include "file", insert txt output in buffer below src block. TINYCHANGE --- etc/ORG-NEWS| 7 +++ lisp/ob-plantuml.el | 13 ++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS