Re: [PATCH v2] org-attach.el: ID to path functions may return nil

Max Nikulin writes: >>> Please, remove a stray space in the defcustom. >> >> Hmm. Done. >> >> I just have a habit to add space in the first item in a list because it >> helps auto-indentation. > > I had an impression that something was wrong with indentation of next > entries. I thought that

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

On 15/11/2022 09:41, Ihor Radchenko wrote: Max Nikulin writes: Please, remove a stray space in the defcustom. Hmm. Done. I just have a habit to add space in the first item in a list because it helps auto-indentation. I had an impression that something was wrong with indentation of next en

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

Max Nikulin writes: > On 14/11/2022 10:29, Ihor Radchenko wrote: >> >> I went through the patch and tried to clarify the wording. >> Especially in the defcustom docstring. > > I do not mind in general. > > Please, remove a stray space in the defcustom. Hmm. Done. I just have a habit to add spa

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

On 14/11/2022 10:29, Ihor Radchenko wrote: I went through the patch and tried to clarify the wording. Especially in the defcustom docstring. I do not mind in general. Please, remove a stray space in the defcustom. I also added the dumb fallback to the default value. I feel that otherwise th

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

Max Nikulin writes: >> However, please add NEWS entry detailing the change in >> `org-attach-id-to-path-function-list' to the next version of the patch. > > See the attachment. Thanks! I went through the patch and tried to clarify the wording. Especially in the defcustom docstring. I also adde

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

On 10/11/2022 14:19, Ihor Radchenko wrote: Max Nikulin writes: P.S. At first I believed that you have some objections concerning changed role of the first function in the list, not just how it is documented. I had. Most importantly, because we are changing the existing meaning of `org-attach-

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

Max Nikulin writes: > On 08/11/2022 12:08, Ihor Radchenko wrote: >> >> I feel like this makes the docstring confusing. >> >> Note that `org-attach-id-to-path-function-list': > > I have tried to update the docstrings. Thanks! >>> if: No attachment directory is associated with the current node,

Re: [PATCH v2] org-attach.el: ID to path functions may return nil

Max Nikulin Date: Mon, 7 Nov 2022 23:48:02 +0700 Subject: [PATCH v2] org-attach.el: ID to path functions may return nil * lisp/org-attach.el (org-attach-dir-from-id): Ignore nil values returned by entries from `org-attach-id-to-path-function-list'. (org-attach-dir-get-create): Update error