Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Bastien writes: > Ihor Radchenko writes: > >> If you confirm, I can just remove the call to `org-fold-reveal'. > > Yes, I do confirm -- thanks for the quick feedback. Fixed in 4280762e4. Best, Ihor

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Ihor Radchenko writes: > I think I addressed the raised issues. > Just merged org-fold upstream. 👏 > Kévin Le Gouguec writes: > >> My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): >> >> $ git switch feature/org-fold-universal-core-tidy >> $ make autoloads >> $ emacs -Q -

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Ihor Radchenko writes: > If you confirm, I can just remove the call to `org-fold-reveal'. Yes, I do confirm -- thanks for the quick feedback. -- Bastien

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Bastien writes: > Ihor Radchenko writes: > >> I think I addressed the raised issues. >> Just merged org-fold upstream. > > Great! Thanks again for the hard work and the merge. > > One glitch: when refiling an entry to a folded section, the section > gets unfolded. > > Can you reproduce this? L

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Hi Ihor, Ihor Radchenko writes: > I think I addressed the raised issues. > Just merged org-fold upstream. Great! Thanks again for the hard work and the merge. One glitch: when refiling an entry to a folded section, the section gets unfolded. Can you reproduce this? Let me know if you need a

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

I think I addressed the raised issues. Just merged org-fold upstream. Kévin Le Gouguec writes: > My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): > > $ git switch feature/org-fold-universal-core-tidy > $ make autoloads > $ emacs -Q -L lisp -eval "(setq org-startup-folded

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

I think I addressed the raised issues. Just merged org-fold upstream. Kévin Le Gouguec writes: > My recipe (based on commit f9dd109bc, Emacs 29.0.50 commit 864c8013fd): > > $ git switch feature/org-fold-universal-core-tidy > $ make autoloads > $ emacs -Q -L lisp -eval "(setq org-startup-folded

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Hey Ihor! Ihor Radchenko writes: > This is the final version of the patch. I am going to merge it this > weekend. If there are any comments, please send them ASAP. I've thrown a couple of LOGBOOK-heavy Org files at your branch; I'm observing something that I can't make sense of. I tried to con

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Ihor Radchenko writes: > https://github.com/yantar92/org/tree/feature/org-fold-universal-core-tidy Thanks -- I confirm the bug I reported is not present in this branch. -- Bastien

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Bastien writes: >> Since the actual patch does not have the problem, I'd prefer to ignore >> this problem unless it appears again after merging. > > Sure - can you point the exact branch/commit I should test for the > version that will be merged? https://github.com/yantar92/org/tree/feature/org

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Hi Ihor, thanks for double-checking this. Ihor Radchenko writes: > Since the actual patch does not have the problem, I'd prefer to ignore > this problem unless it appears again after merging. Sure - can you point the exact branch/commit I should test for the version that will be merged? --

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Bastien writes: > I'm on commit e0abbbacf9427b69482c6c47c3ea0975b0e6fa6d from the > feature/org-fold-universal-core branch of your org repo. > > Using Emacs 29.0.50 and this as the content for ~/test.org: > > * TODO [[https://orgmode.org][test]] > SCHEDULED: <2022-04-20 mer.> > > Then run: > > -

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Ihor Radchenko writes: > Bastien writes: > >> One glitch: in an agenda view with an agenda item that has a link, >> changing the todo state will make all parts of the link visible. >> >> Let me know if you need a more detail recipe to reproduce the bug. > > Recipe would be helpftul. I was unable

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Bastien writes: > One glitch: in an agenda view with an agenda item that has a link, > changing the todo state will make all parts of the link visible. > > Let me know if you need a more detail recipe to reproduce the bug. Recipe would be helpftul. I was unable to reproduce using * TODO this is

Re: [PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

Hi Ihor, thanks for your work on this. Ihor Radchenko writes: > This is the final version of the patch. I am going to merge it this > weekend. If there are any comments, please send them ASAP. One glitch: in an agenda view with an agenda item that has a link, changing the todo state will make

[PATCH v2 00/38] Final call for comments: Merge org-fold feature branch

This is the final version of the patch. I am going to merge it this weekend. If there are any comments, please send them ASAP. This version is basically the same as previous, but (1) Rebased onto current main; (2) org-agenda.el can be native compiled; (3) Fixed some edge cases with fontification.