Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters

2022-06-21 Thread Max Nikulin
On 21/06/2022 19:03, Hugo Heagren wrote: +(defmacro test-ol-with-link-parameters-as (type parameters body) [...] + `(progn + (setq orig-parameters org-link-parameters) I can easily miss something, but wouldn't it be enough to use let-binding `(let ((org-link-parameters

Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters

2022-06-21 Thread Robert Pluim
> On Tue, 21 Jun 2022 13:03:32 +0100, Hugo Heagren said: Hugo> They're very nearly just right, but for some reason Hugo> `test-ol-with-link-parameters-as' doesn't always reset the parameters Hugo> correctly for me. However I have them set to originally, it sets Hugo>

Re: [PATCH v3] ol.el: add description format parameter to org-link-parameters

2022-06-21 Thread Hugo Heagren
I've finally had time to the `:default-description' parameter in `org-link-parameters'. Ihor Radchenko writes: > I recommend writing tests for org-insert-link in > testing/lisp/test-ol.el and testing expected behaviour for various > values of :default-description. Good advice! I haven't