Re: [PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-11-06 Thread Ihor Radchenko
Ihor Radchenko writes: > I will be happy to merge a proper patch upon addressing possible > pitfalls. I do not feel strongly about my variant vs. yours. Max, do you have any update here? If not, I will merge my variant as it should not break anything. -- Ihor Radchenko // yantar92, Org mode

Re: [PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-10-04 Thread Ihor Radchenko
Max Nikulin writes: >> The new version of the patch allows all but first function return nil. >> See the attached. >> >> Let me know if there are any other objections. > > Ihor, sorry that I left your earlier questions with no response. I hope, > the attached diff may illustrate my ideas

Re: [PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-10-04 Thread Max Nikulin
On 02/10/2022 16:14, Ihor Radchenko wrote: Ihor Radchenko writes: Max Nikulin writes: The new version of the patch allows all but first function return nil. See the attached. Let me know if there are any other objections. Ihor, sorry that I left your earlier questions with no response. I

[PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]

2022-10-02 Thread Ihor Radchenko
Ihor Radchenko writes: > Max Nikulin writes: > >>> I do not think that it is a good idea. We currently promise to use the >>> first function in the list to generate the IDs. Other functions are >>> mostly a fallback to catch the existing attach dirs created in the past >>> using different ID