Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

2023-03-21 Thread Max Nikulin
On 19/03/2023 21:42, Ken Mankoff wrote: Here is the other patch. Respect custom screen command. Thanks, Ken. +++ b/lisp/ob-screen.el @@ -98,7 +98,7 @@ In case you want to use a different screen than one selected by your $PATH") (defun org-babel-screen-session-socketname (session)

Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

2023-03-19 Thread Ken Mankoff
Hi Max, On 2023-03-16 at 11:09 -04, Max Nikulin wrote... > Ken, you wrote that you have other patches for ob-screen.el. Do you > plan to sent them? Here is the other patch. Respect custom screen command. -k. >From ff919de09e020fa053f5727f3b36026a3a773f88 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

2023-03-18 Thread Ihor Radchenko
Max Nikulin writes: > Ken, you wrote that you have other patches for ob-screen.el. Do you plan > to sent them? For context, Ken is the maintainer of ob-screen. It is up to him is this feature is useful for ob-screen, with your additions. -- Ihor Radchenko // yantar92, Org mode contributor,

Re: [PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

2023-03-17 Thread Max Nikulin
On 16/03/2023 22:09, Max Nikulin wrote: +(defun org-babel-variable-assignments:screen (params) ...> (defvar org-babel-screen-location "screen" Perhaps `defun' should be moved below `defvar's.

[PATCH v4] lisp/ob-screen.el: Support ~:var~ header args for babel blocks

2023-03-16 Thread Max Nikulin
On 16/03/2023 17:22, Ihor Radchenko wrote: Canceled. Anyway it does not work. I have tried to "fix" `org-babel-variable-assignments:screen' by an extra patch. Perhaps executable name aka :cmd and babel language should not be rigidly coupled and it may be subject for further improvement.