Ihor Radchenko writes:
> All the tests are passing now on my side.
>
> I'll postpone merging to next week to make sure that there are no more
> comments.
Applied onto main via e08ce5b27, ae1db7df3, 8908a1bda, f3802b017,
a4105d094, a18969768, and 132a9d304 after resolving a trivial merge
conflict
Max Nikulin writes:
>>> I do not like repeating of `org-encode-time' but do not see another way
>>> till Emacs-29 will become the lowest supported version.
>>
>> This is fine. AFAIK, other parts of time handling code is full of conds
>> and pcases.
>
> I mean that before my patch there was singl
On 11/05/2022 20:20, Ihor Radchenko wrote:
Max Nikulin writes:
+ ;; In Emacs-27 and Emacs-28 `encode-time' does not support 6
elements
+ ;; list argument so `org-encode-time' can not be outside of
`pcase'.
+ (pcase-let
+ ((`(,_ ,_ ,_ ,d
Max Nikulin writes:
>> + (defmacro org-encode-time (&rest time)
>> +(pcase (length time) ; Emacs-29 since d75e2c12eb
>> + (1 `(encode-time ,@time))
>> + ((or 6 9) `(encode-time (list ,@time)))
>> + (_ (error "`org-encode-time' may be called with 1, 6, or 9
On 05/05/2022 22:22, Max Nikulin wrote:
On 04/05/2022 16:56, Ihor Radchenko wrote:
Max Nikulin writes:
Resetting timezone to UTC should be fixed in timestamps generated by a
testing helper function. I was disappointed that `mapcar' can not be
used with multiple lists, but I have found an old
Max Nikulin writes:
> On 04/05/2022 16:56, Ihor Radchenko wrote:
>> Max Nikulin writes:
>>
>> 1 unexpected results:
>> FAILED test-org-clock/clocktable/ranges
>
> Resetting timezone to UTC should be fixed in timestamps generated by a
> testing helper function. I was disappointed that `mapc
On 04/05/2022 16:56, Ihor Radchenko wrote:
Max Nikulin writes:
1 unexpected results:
FAILED test-org-clock/clocktable/ranges
Resetting timezone to UTC should be fixed in timestamps generated by a
testing helper function. I was disappointed that `mapcar' can not be
used with multiple lis
