Re: [patch] ob-clojure: Fix results output

Ihor Radchenko writes: >> Or rather something like: >> >> (defun ob-clojure-eval-with-cider (expanded _params cljs-p) >> "Evaluate EXPANDED code block using cider. >> When CLJS-P is non-nil, use a cljs connection instead of clj. >> The PARAMS from Babel are not used in this function." > > I

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > Ihor Radchenko writes: > >> Now, the docstring appears to be a bit confusing: >> >> (defun ob-clojure-eval-with-cider (expanded _params cljs-p) >> "Evaluate EXPANDED code block with PARAMS using cider. >> When CLJS-P is non-nil, use a cljs connection instead of clj."

Re: [patch] ob-clojure: Fix results output

Ihor Radchenko writes: > Now, the docstring appears to be a bit confusing: > > (defun ob-clojure-eval-with-cider (expanded _params cljs-p) > "Evaluate EXPANDED code block with PARAMS using cider. > When CLJS-P is non-nil, use a cljs connection instead of clj." > > It would be useful to

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > Ihor Radchenko writes: > >> I note that we now have a new compiler warning after your changes: >> ⛔ Warning (comp): ob-clojure.el:268:45: Warning: Unused lexical argument >> ‘params’ >> >> May you please take a look? >> If the function argument is really unused, replace

Re: [patch] ob-clojure: Fix results output

Ihor Radchenko writes: > I note that we now have a new compiler warning after your changes: > ⛔ Warning (comp): ob-clojure.el:268:45: Warning: Unused lexical argument > ‘params’ > > May you please take a look? > If the function argument is really unused, replace it with _ in >

Re: [patch] ob-clojure: Fix results output

Ihor Radchenko writes: > Feel free to push. I note that we now have a new compiler warning after your changes: ⛔ Warning (comp): ob-clojure.el:268:45: Warning: Unused lexical argument ‘params’ May you please take a look? If the function argument is really unused, replace it with _ in

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > Attached a new patch. Thanks! I have no further comments. Feel free to push. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at

Re: [patch] ob-clojure: Fix results output

Ihor Radchenko writes: > What will happen with users who customized `org-babel-clojure-backend' > to 'nbb in the past? They would have gotten an error. I changed it now that 'nbb backend is still allowed in a clojure source block but it will internally treated as ClojureScript. >> +(defcustom

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > Ups, I attached the wrong one. > Here the correct patch.. Thanks! Some more comments ;) > (defcustom org-babel-clojure-backend (cond >((executable-find "bb") 'babashka) > - ((executable-find

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > Attached is the new patch with the changes. > > [2. text/x-patch; 0001-lisp-ob-sql.el-Add-support-for-Athena.patch]... Ups, I attached the wrong one. Here the correct patch.. >From db0634b5ab0b5c8c996c5dcbbeb266b720c67459 Mon Sep 17 00:00:00 2001 From: Daniel Kraus

Re: [patch] ob-clojure: Fix results output

Hi! Ihor Radchenko writes: > Daniel Kraus writes: > >> This was apparently a kludge that ob-clojure used to evaluate ClojureScript >> in the normal clojure:execute function. >> I simply used the same kludge where I need to check for cljs, but after >> reviewing it's not really necessary and I

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: >> Also, make sure that >> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html >> is up-to-date. > > Good reminder. I send a PR for this when this patch is installed?! Or together. Either way is fine. >> Note: I do not see :target header arg being

Re: [patch] ob-clojure: Fix results output

Hi! Ihor Radchenko writes: > You need to document the changes in ORG-NEWS. I added an entry about the new ClojureScript change. I guess the other (main) part of the patch is a bugfix and will not be documented in ORG-NEWS. > Also, see inline comments below. > >> Subject: [PATCH]

Re: [patch] ob-clojure: Fix results output

Daniel Kraus writes: > attached is a bigger patch that fixes the result output of ob-clojure. > The commit message contains examples what's currently wrong > and what's fixed. > This is a breaking change though. > So if someone before relied on the fact that, e.g. cider, returns > the result of

[patch] ob-clojure: Fix results output

Hi, attached is a bigger patch that fixes the result output of ob-clojure. The commit message contains examples what's currently wrong and what's fixed. This is a breaking change though. So if someone before relied on the fact that, e.g. cider, returns the result of every expression in every line