Re: Babel (scheme): Evaluation errors are not shown

2023-01-25 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: >> > Rebased against the latest main. Please see the appended patch. Applied, onto main, adding TINYCHANGE cookie and removing "." from the commit summary. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f35fb8ac2 You are now also listed as Org

Re: Babel (scheme): Evaluation errors are not shown

2023-01-07 Thread Marc Nieper-Wißkirchen
Am Sa., 7. Jan. 2023 um 08:44 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > >> Thanks! > >> Note that your patch does not apply onto main. > > > > Rebased against the latest main. Please see the appended patch. > > Hmm. > Not sure what is going on here, but I am getting > >

Re: Babel (scheme): Evaluation errors are not shown

2023-01-07 Thread Bastien Guerry
Ihor Radchenko writes: > As for GCC-related assignment, I am not sure if it is sufficient. I confirm that the copyright assignment should explicitely mention EMACS as a GNU project. -- Bastien

Re: Babel (scheme): Evaluation errors are not shown

2023-01-06 Thread Marc Nieper-Wißkirchen
Am Fr., 6. Jan. 2023 um 17:34 Uhr schrieb : > > On Fri, Jan 06, 2023 at 04:20:29PM +, Ihor Radchenko wrote: > > Ihor Radchenko writes: > > > > > Marc Nieper-Wißkirchen writes: > > > ... > > > > May someone forward my last email to Marc? > > For some reason, his mail server classifies my

Re: Babel (scheme): Evaluation errors are not shown

2023-01-06 Thread Rudolf Adamkovič
Bastien writes: > Sure, done. Thank you for your understanding, Bastien! > (Or write ob-fennel.el?) It already exists, FYI: https://gitlab.com/andreyorst/ob-fennel Rudy -- "Simplicity is complexity resolved." -- Constantin Brâncuși, 1876-1957 Rudolf Adamkovič [he/him] Studenohorská 25

Re: Babel (scheme): Evaluation errors are not shown

2023-01-06 Thread tomas
On Fri, Jan 06, 2023 at 04:20:29PM +, Ihor Radchenko wrote: > Ihor Radchenko writes: > > > Marc Nieper-Wißkirchen writes: > > ... > > May someone forward my last email to Marc? > For some reason, his mail server classifies my emails as spam and > rejects them. Just tried. Happens for me

Re: Babel (scheme): Evaluation errors are not shown

2023-01-06 Thread Ihor Radchenko
Ihor Radchenko writes: > Marc Nieper-Wißkirchen writes: > ... May someone forward my last email to Marc? For some reason, his mail server classifies my emails as spam and rejects them. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

Re: Babel (scheme): Evaluation errors are not shown

2023-01-06 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > Despite the unfortunate lack of a maintainer, I hope the (latest > version of the) patch can still be applied as the current behavior of > ob-scheme.el, namely, silencing any evaluation errors is infeasible. Yes, it can. Can you please take a look at patch

Re: Babel (scheme): Evaluation errors are not shown

2023-01-05 Thread Marc Nieper-Wißkirchen
Despite the unfortunate lack of a maintainer, I hope the (latest version of the) patch can still be applied as the current behavior of ob-scheme.el, namely, silencing any evaluation errors is infeasible. Do you need any FSF copyright assignments from me? (I already contributed to GCC and Gnulib

Re: Babel (scheme): Evaluation errors are not shown

2023-01-03 Thread Bastien
Hi Rudolf, Rudolf Adamkovič writes: > So, my use of Scheme drops from 8 hours per day to effectively 0, > effective today. As a result, I would like to kindly ask you to revert > the change, for without actively using something, I cannot maintain it. Sure, done. > That said, if my employer

Re: Babel (scheme): Evaluation errors are not shown

2023-01-03 Thread Rudolf Adamkovič
Bastien Guerry writes: > I just added you as the maintainer of ob-scheme.el. A sudden turn of events: My employer have just decided that we will convert all Scheme to Fennel, a zero-runtime Lisp based on Lua, because it has a better bus factor, meaning that, in the worst-case, the company can

Re: Babel (scheme): Evaluation errors are not shown

2023-01-03 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: >> Thanks! >> Note that your patch does not apply onto main. > > Rebased against the latest main. Please see the appended patch. Hmm. Not sure what is going on here, but I am getting 128 git … am --3way --

Re: Babel (scheme): Evaluation errors are not shown

2023-01-02 Thread Marc Nieper-Wißkirchen
Am Mo., 2. Jan. 2023 um 10:38 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > > Fixed. > > Thanks! > Note that your patch does not apply onto main. Rebased against the latest main. Please see the appended patch. > > > - (setq result (if output > > +

Re: Babel (scheme): Evaluation errors are not shown

2023-01-02 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > Fixed. Thanks! Note that your patch does not apply onto main. > - (setq result (if output > + (let ((err (geiser-eval--retort-error ret))) > +(setq result (cond > + (err nil) We may still

Re: Babel (scheme): Evaluation errors are not shown

2023-01-01 Thread Marc Nieper-Wißkirchen
Fixed. Am So., 1. Jan. 2023 um 14:53 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > > (defun org-babel-eval-error-notify (exit-code stderr) > > - "Open a buffer to display STDERR and a message with the value of > > EXIT-CODE." > > + "Open a buffer to display STDERR and a

Re: Babel (scheme): Evaluation errors are not shown

2023-01-01 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > (defun org-babel-eval-error-notify (exit-code stderr) > - "Open a buffer to display STDERR and a message with the value of > EXIT-CODE." > + "Open a buffer to display STDERR and a message with the value of EXIT-CODE. > +If EXIT-CODE is nil, suppress the

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Marc Nieper-Wißkirchen
Done! Am Sa., 31. Dez. 2022 um 14:24 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > > Please find the patch file attached to this email. > > Thanks! > I will give some general comments and leave the ob-scheme changes for > Rudolf. > > > Subject: [PATCH] Display evaluation

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > Please find the patch file attached to this email. Thanks! I will give some general comments and leave the ob-scheme changes for Rudolf. > Subject: [PATCH] Display evaluation errors for Scheme code blocks. If you can, please provide changelog entries

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Marc Nieper-Wißkirchen
Please find the patch file attached to this email. Thank you, Marc Am Sa., 31. Dez. 2022 um 13:07 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > > Please find attached a version that does not signal an Elisp user > > error, but calls `org-babel-eval-error-notify' instead.

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > Please find attached a version that does not signal an Elisp user > error, but calls `org-babel-eval-error-notify' instead. If you can, could you please send the changes in form of a patch instead? It is then easier to review. See

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Marc Nieper-Wißkirchen
Am Sa., 31. Dez. 2022 um 11:19 Uhr schrieb Marc Nieper-Wißkirchen : > > Am Sa., 31. Dez. 2022 um 11:09 Uhr schrieb Marc Nieper-Wißkirchen > : > > > > Am Sa., 31. Dez. 2022 um 10:49 Uhr schrieb Ihor Radchenko > > : > > > > > > Marc Nieper-Wißkirchen writes: [...] > > > It is not what we

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Marc Nieper-Wißkirchen
Am Sa., 31. Dez. 2022 um 11:09 Uhr schrieb Marc Nieper-Wißkirchen : > > Am Sa., 31. Dez. 2022 um 10:49 Uhr schrieb Ihor Radchenko > : > > > > Marc Nieper-Wißkirchen writes: > > > > > I have been talking to jao (from geiser). The following version of > > > ob-scheme.el signals an error when

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Marc Nieper-Wißkirchen
Am Sa., 31. Dez. 2022 um 10:49 Uhr schrieb Ihor Radchenko : > > Marc Nieper-Wißkirchen writes: > > > I have been talking to jao (from geiser). The following version of > > ob-scheme.el signals an error when executing Scheme code blocks. > > Besides two function declarations, the only change is

Re: Babel (scheme): Evaluation errors are not shown

2022-12-31 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > I have been talking to jao (from geiser). The following version of > ob-scheme.el signals an error when executing Scheme code blocks. > Besides two function declarations, the only change is in the function > org-babel-scheme-execute-with-geiser. Do you mean

Re: Babel (scheme): Evaluation errors are not shown

2022-12-29 Thread Bastien Guerry
Hi Rudolf and Ihor, Ihor Radchenko writes: > Rudolf Adamkovič writes: > >> Ihor Radchenko writes: >> >>> Note that we currently have no maintainer for ob-scheme and hence can >>> only provide very limited support. New features are hard for us >>> without experience with scheme and geiser. >>

Re: Babel (scheme): Evaluation errors are not shown

2022-12-21 Thread Ihor Radchenko
Rudolf Adamkovič writes: > Ihor Radchenko writes: > >> Note that we currently have no maintainer for ob-scheme and hence can >> only provide very limited support. New features are hard for us >> without experience with scheme and geiser. > > I volunteer to maintain `ob-scheme'. > > (I use

Re: Babel (scheme): Evaluation errors are not shown

2022-12-20 Thread Marc Nieper-Wißkirchen
I have been talking to jao (from geiser). The following version of ob-scheme.el signals an error when executing Scheme code blocks. Besides two function declarations, the only change is in the function org-babel-scheme-execute-with-geiser. ;;; ob-scheme.el --- Babel Functions for Scheme -*-

Re: Babel (scheme): Evaluation errors are not shown

2022-12-19 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Note that we currently have no maintainer for ob-scheme and hence can > only provide very limited support. New features are hard for us > without experience with scheme and geiser. I volunteer to maintain `ob-scheme'. (I use Scheme and Geiser heavily at work, albeit

Re: Babel (scheme): Evaluation errors are not shown

2022-12-18 Thread Ihor Radchenko
Marc Nieper-Wißkirchen writes: > When I evaluate erroneous code of an Elisp code block like > > #+BEGIN_SRC elisp > (x) > #+END_SRC > > I see the error message ("Symbol's function definition is void: x") in > the minibuffer (and in the *Messages* buffer). > > This is not the case with Scheme

Babel (scheme): Evaluation errors are not shown

2022-12-16 Thread Marc Nieper-Wißkirchen
When I evaluate erroneous code of an Elisp code block like #+BEGIN_SRC elisp (x) #+END_SRC I see the error message ("Symbol's function definition is void: x") in the minibuffer (and in the *Messages* buffer). This is not the case with Scheme code blocks; evaluating the code block #+BEGIN_SRC