Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]

2021-04-27 Thread No Wayman
Kyle Meyer writes: Bastien writes: Hi, thanks for the patch, we do indeed need to move forward for this. Could you propose the patch against the master branch (not the maint branch, since this is not a bugfix) and perhaps fix *all* warnings? Thanks, but these were already taken

Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]

2021-04-26 Thread Bastien
Hi Kyle, Kyle Meyer writes: > Bastien writes: > >> Hi, >> >> thanks for the patch, we do indeed need to move forward for this. >> >> Could you propose the patch against the master branch (not the maint >> branch, since this is not a bugfix) and perhaps fix *all* warnings? > > Thanks, but these

Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]

2021-04-26 Thread Kyle Meyer
Bastien writes: > Hi, > > thanks for the patch, we do indeed need to move forward for this. > > Could you propose the patch against the master branch (not the maint > branch, since this is not a bugfix) and perhaps fix *all* warnings? Thanks, but these were already taken care of by 8c29cbdef

Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]

2021-04-26 Thread Bastien
Hi, thanks for the patch, we do indeed need to move forward for this. Could you propose the patch against the master branch (not the maint branch, since this is not a bugfix) and perhaps fix *all* warnings? Also, here the preferred format for the commit message: * lisp/org-table.el

Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)]

2021-04-26 Thread No Wayman
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.