Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-20 Thread Eric S Fraga
On Saturday, 18 Apr 2020 at 16:30, Marco Wahl wrote: > Indeed, why not? I pushed a respective change. I introduced a subtlety > when deleting from the rightmost column or from immediately right of the > table. That was not needed with point moving to the left, as it has > been before. This

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-18 Thread Marco Wahl
Hi, And thanks, Eric! Eric S Fraga writes: > Now, I might be pushing my luck so apologies but: it would be nice if > the kill row/column behaviour were also consistent. Right now, if you > kill a row, it leaves point where it was; if you kill a column, it moves > point to the previous column.

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-18 Thread Eric S Fraga
On Saturday, 18 Apr 2020 at 00:51, Marco Wahl wrote: > Okay, pushed. Thank you! Seems to work very well. Now, I might be pushing my luck so apologies but: it would be nice if the kill row/column behaviour were also consistent. Right now, if you kill a row, it leaves point where it was; if you

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-17 Thread Marco Wahl
Nicolas Goaziou writes: >> Where shall the change go? maint (and master) or just to master? > > I think maint is fine. Okay, pushed. Thanks, -- Marco

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-17 Thread Nicolas Goaziou
Hello, Marco Wahl writes: > I had a look at the issue and I think I can take over the > implementation. It's not a big deal AFAICS. Thank you. > Where shall the change go? maint (and master) or just to master? I think maint is fine. Regards, -- Nicolas Goaziou

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-17 Thread Marco Wahl
Hi, Carsten Dominik writes: >> > I just pulled the lates master, and I think the creation of a new >> > column has not been set back to the way it used to be, even though >> > Nicolas agreed to do so. Am I missing something? >> As I understood, we practice some patience now to see if someone

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-01 Thread Carsten Dominik
Hi Marco, thank you for the reply. For the record, I am in favor of the old workings, as described by Eric. It is more consistent in several ways. Carsten On Wed, Apr 1, 2020 at 7:52 PM Marco Wahl wrote: > Hi Carsten, > > > I just pulled the lates master, and I think the creation of a new

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-01 Thread Marco Wahl
Hi Carsten, > I just pulled the lates master, and I think the creation of a new column > has not been set back to the way it used to be, even though Nicolas agreed > to do so. Am I missing something? As I understood, we practice some patience now to see if someone votes for keeping the current

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-01 Thread Carsten Dominik
Hi, I just pulled the lates master, and I think the creation of a new column has not been set back to the way it used to be, even though Nicolas agreed to do so. Am I missing something? Thanks. Carsten On Tue, Mar 31, 2020 at 10:10 PM Nicolas Goaziou wrote: > Eric S Fraga writes: > > > And

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-01 Thread Nicolas Goaziou
Hello, Marco Wahl writes: > Since the change has been in place since 2017 what's the right thing to > do? > > - Wait a while for someone speaking out to keep the state as it is now? > If nobody shows up, just change back to inserting to the left? That, and documenting it in ORG-NEWS, sounds

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-04-01 Thread Marco Wahl
Nicolas Goaziou writes: > Eric S Fraga writes: > >> And I believe that a reasonable expectation is symmetry with inserting a >> row. The way I think of it is the arrow indicates to make space by >> moving columns/rows in that direction. Most spreadsheets work in this >> way, in my experience

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-31 Thread Nicolas Goaziou
Eric S Fraga writes: > And I believe that a reasonable expectation is symmetry with inserting a > row. The way I think of it is the arrow indicates to make space by > moving columns/rows in that direction. Most spreadsheets work in this > way, in my experience (but I could be wrong). I

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-31 Thread Eric S Fraga
On Tuesday, 31 Mar 2020 at 16:05, Nicolas Goaziou wrote: > Hello, > > Well, since I apparently made the change, I have to speak for it. Thank you. It's good to discuss! > When one presses M-S-Right in order to create a new column, I think > a reasonable expectation is : > > 1. to move point to

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-31 Thread Julius Dittmar
Am 31.03.20 um 16:05 schrieb Nicolas Goaziou: > Note that adding a column to the beginning of the row is easy: just type > "|" near the beginning of the first cell. Does not seem correct. I had table #+begin_src org | 1 | 2 | | 3 | 4 | #+end_src Adding a | at the beginning of the first cell

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-31 Thread Nicolas Goaziou
Hello, Eric S Fraga writes: > On Monday, 30 Mar 2020 at 23:22, Kyle Meyer wrote: >> It looks like the documentation became stale with b8d473a04 (org-table: >> Insert new column to the right instead of the left, 2017-11-19). Thanks >> for updating it. > > Annoyingly, I would have preferred to

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-31 Thread Eric S Fraga
On Monday, 30 Mar 2020 at 23:22, Kyle Meyer wrote: > It looks like the documentation became stale with b8d473a04 (org-table: > Insert new column to the right instead of the left, 2017-11-19). Thanks > for updating it. Annoyingly, I would have preferred to have the column inserted to the left of

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-30 Thread Kyle Meyer
Marco Wahl writes: > I find it slightly suspicious that the documentation says > > #v+ > ‘M-S-’ (‘org-table-insert-column’) > Insert a new column to the left of point position. > #v- > > But actually the new column goes to the right and this is also fused by > the tests. Has there been a

Re: Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-30 Thread Marco Wahl
Yu Han Quek writes: > Calling org-table-insert-column in a table with formulas wrongly increments > the column number left of the newly inserted column. > > Minimal example: > > | 1 | 2 | 3 | > > #+TBLFM: $3=$1+$2 > > With cursor in the `1` cell, call `M-x org-table-insert-column`. > > Expected

Bug: org-table-insert-column edits formulas wrongly [9.3 (release_9.3 @ /usr/local/Cellar/emacs-plus/HEAD-9d38564/share/emacs/28.0.50/lisp/org/)]

2020-03-30 Thread Yu Han Quek
Calling org-table-insert-column in a table with formulas wrongly increments the column number left of the newly inserted column. Minimal example: | 1 | 2 | 3 | #+TBLFM: $3=$1+$2 With cursor in the `1` cell, call `M-x org-table-insert-column`. Expected output: | 1 | | 2 | 3 | #+TBLFM: