Thanks for the patch, and others for the review/feedback.
Alan Light writes:
> Subject: [PATCH 2/2] ob-sql.el: ob-sql.el (org-babel-execute:sql): Use
> `sql-postgres-program' as postgresql executable (instead of psql) when
> defined
>
> * ob-sql.el (org-babel-execute:sql): Use `sql-postgres-p
It looks like the two patches are sequential, there should probably be
a rebase into a single patch. I would remove the comment in the second
patch because it is a single command to jump to the default value and
it might change in the future, so no reason to put it in a comment.
One way to communic
> when defined. psql will
For future: You need to use 2 spaces after sentence end ^_^. As I
understand, these NEWS entries must have specific formatting to be
harvested automatically into NEWS file. So, patches should comply with
all the requirements listed in https://orgmode.org/worg/org-contribu
New patch file attached.
On Sat, Dec 12, 2020 at 7:14 PM Ihor Radchenko wrote:
> Alan Light writes:
>
> > Sorry, I don't understand. That's what I did. The patch was attached to
> my
> > email.
>
> You need to add patch description, not just title. Something like:
>
> * ob-sql.el (org-babel-ex
Alan Light writes:
> Sorry, I don't understand. That's what I did. The patch was attached to my
> email.
You need to add patch description, not just title. Something like:
* ob-sql.el (org-babel-execute:sql): Use `sql-postgres-program' as
postgresql executable (instead of psql) when defined.
Sorry, I don't understand. That's what I did. The patch was attached to my
email.
On Sat, Dec 12, 2020 at 1:32 PM Bastien wrote:
> Hi Alan,
>
> Alan Light writes:
>
> > ob-sql.el does not respect the value of sql-postgres-program, thus
> > causing problem when running on Windows, etc.
> > Patch
Hi Alan,
Alan Light writes:
> ob-sql.el does not respect the value of sql-postgres-program, thus
> causing problem when running on Windows, etc.
> Patch attached.
Thanks. Can someone confirm the patch is good?
Alan, can you check how to submit a patch with a changelog on this
page: https://or
ob-sql.el does not respect the value of sql-postgres-program, thus causing
problem when running on Windows, etc.
Patch attached.
0001-Respect-the-value-of-sql-postgres-program-as-opposed.patch
Description: Binary data
