Hi Ihor,
Ihor Radchenko writes:
> The change in (eval ...) call inside org-diary-sexp-entry broke sexp
> timestamps. See orgmode.org/list/875ynnojvf.fsf@localhost
Fixed, thanks!
--
Bastien
Bastien Guerry writes:
> Stefan Monnier writes:
>
>> The patch below gets rid of the old `defadvice`, replacing it with
>> `advice-add`.
>
> Applied in the main branch as 6d73cd34a, thanks a lot!
The change in (eval ...) call inside org-diary-sexp-entry broke sexp
timestamps. See orgmode.org/li
> i was ok with the scold for a long time about (` thing but my reactin
> time slowed significantly and that was trivial-er.
The (` transition was not handled ideally, to be honest: we declared
them obsolete very early but only started emitting warnings much later,
so the transition period have se
On 3/31/22, Stefan Monnier wrote:
> I definitely hope it will be gone before 2040, but it hasn't even been
> declared officially obsolete yet (not even in `master`), so I think you
> should be good at least until 2030.
thanks.
i was ok with the scold for a long time about (` thing but my reactin
Hi Stefan,
Stefan Monnier writes:
> The patch below gets rid of the old `defadvice`, replacing it with
> `advice-add`.
Applied in the main branch as 6d73cd34a, thanks a lot!
--
Bastien
> thank you. just an idle question. is it common/desirable for built
> in packages to use advice instead of hooks and such?
Desirable? no.
Common? kinda, yes, sadly.
It's usually good to look at the existing advice as "requests for hooks".
I haven't spent the energy to look at them this way, tho
thank you. just an idle question. is it common/desirable for built
in packages to use advice instead of hooks and such?
also, merely as a plea from a user, i hope defadvice will stick around
for all that user and non-built-in and abandoned code.
On 3/31/22, Stefan Monnier wrote:
> The patch be
The patch below gets rid of the old `defadvice`, replacing it with `advice-add`.
It also includes some FIXMEs about things I found along the way which
look suspicious (they're not directly related to the patch, tho, nor
are they affected by it AFAICT).
Stefan
2022-03-31 Stefan Monnier