Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-30 Thread Ihor Radchenko
Jens Schmidt writes: > Attached is a patch and commit message with: > > - patch payload unchanged, > > - email address in commit message fixed > > - link to this thread in commit message added. > > Does look right now? Yup. Applied, onto main.

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-30 Thread Jens Schmidt
On 2023-07-29 09:04, Ihor Radchenko wrote: Thanks for checking! Updated our records. And thanks for doing the paperworks. Attached is a patch and commit message with: - patch payload unchanged, - email address in commit message fixed - link to this thread in commit message added. Does

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-29 Thread Ihor Radchenko
Bastien Guerry writes: >> Bastien, may your please check FSF records? > > Done, Jens records are okay. Thanks for contributing! Thanks for checking! Updated our records. https://git.sr.ht/~bzg/worg/commit/95559f89 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-28 Thread Bastien Guerry
Hi Ihor and Jens, Ihor Radchenko writes: > Bastien, may your please check FSF records? Done, Jens records are okay. Thanks for contributing! -- Bastien Guerry

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-27 Thread Eric Abrahamsen
Jens Schmidt writes: > Uh, I had technical issues and did not get all mails as I expected. > Cobbling things together in one big reply now, with references and > quotes hopelessly broken ... hope you can sort it out. > > Anyway, thanks to Eric for chiming in. > >> Ideally, it would be nice to

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-27 Thread Ihor Radchenko
Jens Schmidt writes: > I completed already an FSF copyright assignment for Emacs. Does that > count for org-mode as well or do I need to extend/repeat that somehow? No, you don't need to do anything. Org mode is a part of Emacs. Bastien, may your please check FSF records? -- Ihor Radchenko

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-26 Thread Jens Schmidt
On 2023-07-26 18:04, Ihor Radchenko wrote: This is not a proper email address and name. Should I use Jens Schmidt ? Sorry, forgot to maintain that yet in my org-mode clone. Will do. May you please add TINYCHANGE cookie to commit message. I do not see you having a copyright status in our

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-26 Thread Ihor Radchenko
Jens Schmidt writes: > Package: Org mode version 9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ > /home/jschmidt/work/org-mode/lisp/) > From e1bc9aefd4fd0080012c172d1c21c684a5b2fe51 Mon Sep 17 00:00:00 2001 I looked into applying your patch, but there are several minor issues I need to clarify. >

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-25 Thread Ihor Radchenko
Jens Schmidt writes: > > Ideally, it would be nice to have tests, though I have no clue how to > > approach writing them. > > I have created a somewhat minimal Gnus setup to develop and test this > patch on my development laptop, where I normally do not use Gnus. It > consists of a bunch of

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-24 Thread Jens Schmidt
Uh, I had technical issues and did not get all mails as I expected. Cobbling things together in one big reply now, with references and quotes hopelessly broken ... hope you can sort it out. Anyway, thanks to Eric for chiming in. > Ideally, it would be nice to have tests, though I have no clue

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-24 Thread Max Nikulin
On 23/07/2023 21:13, Jens Schmidt wrote: Gnus can have a global Message-ID cache, but it's not on by default (at least not in Emacs 28, haven't checked others).  And anyway, it's a potentially incomplete *cache*, and not an *index*. Thank you for clarification. Certainly just Message-ID is not

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-24 Thread Ihor Radchenko
Eric Abrahamsen writes: > Ugh, this whole thing is a mess. I think the first question is: should > this function "fix" the state of Gnus before it makes a link? Should it > attempt to re-open the Summary buffer if it's been closed? Should it > switch current articles if the open article buffer

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-23 Thread Eric Abrahamsen
Ihor Radchenko writes: > Eric Abrahamsen writes: > >> We should definitely be using the paradigm above (using the >> gnus-summary-buffer as the current buffer). The article number fetching >> only works by accident in the article buffer, and other stuff (like >> finding the original nnselect

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-23 Thread Jens Schmidt
On 2023-07-23 12:26, Max Nikulin wrote: Is nnselect a real NNTP group or is it some instance existing solely in user's configuration? Like nnvirtual and nnir, nnselect exists only in user's configuration, yes. All these three backends are "wrapper backends" that keep track of the original

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-23 Thread Max Nikulin
On 22/07/2023 16:06, Jens Schmidt wrote: - Create an nnselect group and open an article from that.  In the   article buffer, do M-x org-store-link RET, then paste the link with   C-c C-l in some Org mode buffer.  The resulting link looks like gnus:#e18xcfu-0004ht...@fencepost.gnu.org   That

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-23 Thread Ihor Radchenko
Eric Abrahamsen writes: > We should definitely be using the paradigm above (using the > gnus-summary-buffer as the current buffer). The article number fetching > only works by accident in the article buffer, and other stuff (like > finding the original nnselect group name) won't work at all. I

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-22 Thread Eric Abrahamsen
Jens Schmidt writes: > On 2023-07-22 15:48, Ihor Radchenko wrote: > >> I am not familiar with Gnus, but looking at the code, may it be that >> a Gnus article is open when Gnus summary buffer is not? > > Theoretically yes, if you actively and malignantly kill the summary > buffer, for example.

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-22 Thread Jens Schmidt
On 2023-07-22 15:48, Ihor Radchenko wrote: I am not familiar with Gnus, but looking at the code, may it be that a Gnus article is open when Gnus summary buffer is not? Theoretically yes, if you actively and malignantly kill the summary buffer, for example. In practice and through Gnus key

Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)]

2023-07-22 Thread Ihor Radchenko
Jens Schmidt writes: > The most obvious symptom is this: > > - Create an nnselect group and open an article from that. In the >article buffer, do M-x org-store-link RET, then paste the link with >C-c C-l in some Org mode buffer. The resulting link looks like > >