Hello,
Stig Brautaset writes:
> stardiviner writes:
>
> [...]
>
>> @@ -1486,7 +1521,7 @@ the current topic."
>> (funcall test))
>> (hide-subtree))
>> (push (point) drill-sections)))
>> - "" 'tree))
>> + nil 'tree))
>> (reverse
stardiviner writes:
[...]
> @@ -1486,7 +1521,7 @@ the current topic."
> (funcall test))
> (hide-subtree))
> (push (point) drill-sections)))
> - "" 'tree))
> + nil 'tree))
> (reverse drill-sections)))
Could we have this part o
Nicolas Goaziou writes:
> Hello,
>
> stardiviner writes:
>
>> Oh, sorry, seems yes.
>
> OK. A couple of comments if you don't mind.
>> +(defcustom org-drill-pronounce-command ""
>> + "Org-drill pronounce command."
>> + :type 'string
>> + :safe #'stringp
>> + :group 'org-drill)
>
> This is cl
Hello,
stardiviner writes:
> Oh, sorry, seems yes.
OK. A couple of comments if you don't mind.
> +(defcustom org-drill-pronounce-command ""
> + "Org-drill pronounce command."
> + :type 'string
> + :safe #'stringp
> + :group 'org-drill)
This is clearly not a safe command. You can remove the
Nicolas Goaziou writes:
> Hello,
>
> stardiviner writes:
>
>> Nicolas Goaziou writes:
>>
>>> Hello,
>>>
>>> stardiviner writes:
>>>
A gentle ping..
>>>
>>> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
>>> Paul Sexton. In the long run, I think this package could be
Hello,
stardiviner writes:
> Nicolas Goaziou writes:
>
>> Hello,
>>
>> stardiviner writes:
>>
>>> A gentle ping..
>>
>> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
>> Paul Sexton. In the long run, I think this package could be packaged
>> through ELPA instead.
>
> It i
Nicolas Goaziou writes:
> Hello,
>
> stardiviner writes:
>
>> A gentle ping..
>
> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
> Paul Sexton. In the long run, I think this package could be packaged
> through ELPA instead.
It is indeed not actively maintained. But still
Hello,
stardiviner writes:
> A gentle ping..
I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
Paul Sexton. In the long run, I think this package could be packaged
through ELPA instead.
>> * etc/ORG-NEWS: mentioned this new feature.
Changes to "contrib/" directory are usual
A gentle ping..
stardiviner writes:
> I spend a little time to check out org-drill source code, to find out
> where I can insert hook to run function when presenting word.
>
> Then I finally found the place in ~org-drill-entry~. Here is my patch.
>
> From 81765e9395f5c0bec21d44aeaf16919d35a39e