Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Matt
On Sun, 17 Mar 2024 17:26:48 +0100 Max Nikulin wrote --- > On 17/03/2024 20:42, Matt wrote: > > On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > > > > > (1) revert the commit; (2) re-apply the > > > commit version with the correct author attribution. >

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Max Nikulin
On 17/03/2024 20:42, Matt wrote: On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > > (1) revert the commit; (2) re-apply the > commit version with the correct author attribution. Done. 1. git revert 2. make changes (e.g. emacs followed by *type-type-type* or some i

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Ihor Radchenko
Matt writes: > > We should avoid force pushing unless something is terribly broken. > > What you may do instead is (1) revert the commit; (2) re-apply the > > commit version with the correct author attribution. > > Done. > ... > I added a little section within copyright: > https://git.sr.ht/~

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Matt
On Sun, 17 Mar 2024 11:31:00 +0100 Ihor Radchenko wrote --- > Matt m...@excalamus.com> writes: > > > First, would you like me to update the commit? If so, I will need > > guidance. The correct procedure to change the author after committing to > > remote is unclear to me. I wou

Re: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name)

2024-03-17 Thread Ihor Radchenko
Matt writes: > > For future, we prefer keeping the original commit author in the "author" > > field of the commits - this is important to keep track of the number of > > changed lines for contributors without FSF copyright assignment. > > Thank you for letting me know this is an issue. > > F