Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-03-20 Thread Maxim Nikulin
On 19/03/2021 10:50, Kyle Meyer wrote: Maxim Nikulin writes: A few comments in addition to Eli's advice to drop the (eq system-type 'gnu/linux) condition... Feel free to commit the change suggested in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44824#82 instead of this patch. +(defun org--e

Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-02-19 Thread Maxim Nikulin
On 19/02/2021 21:54, Eli Zaretskii wrote: From: Maxim Nikulin Date: Fri, 19 Feb 2021 19:29:49 +0700 On Windows Emacs always uses pipes, because we don't have PTYs there. And there's no xdg-open on MS-Windows anyway, so it's a moot point. Should I consider your response as a suggestion to remo

Re: bug#44824: [PATCH] org.el: Avoid xdg-open silent failure

2021-02-19 Thread Maxim Nikulin
On 18/02/2021 21:48, Eli Zaretskii wrote: From: Maxim Nikulin Date: Thu, 18 Feb 2021 19:56:03 +0700 I could not estimate effect of such change on windows, so pipe process is used only on linux. I am unsure concerning mac however. On Windows Emacs always uses pipes, because we don't have PTYs t