Re: [PATCH] Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization

2024-01-03 Thread Ihor Radchenko
dark.key8...@151e.ai writes: > Understood. Please find amended patch. Applied, onto main, with minor amendments. I capitalized all the sentences in commit message and added :package-version keyword to the `defcustom' definition. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3aac

Re: [PATCH] Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization

2024-01-02 Thread dark . key8799
On Tue, Jan 2, 2024, at 19:15, Ihor Radchenko wrote: > By convention, abnormal hooks (hooks that require arguments) are named > as *-functions, not *-hook. > > Also, when adding new customizations, we generally announce them in > etc/ORG-NEWS. Understood. Please find amended patch. -- Alexandre

Re: [PATCH] Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization

2024-01-02 Thread Ihor Radchenko
dark.key8...@151e.ai writes: >> I do not see why we shouldn't add such a hook. Patches welcome! > > Would this work? Yes, but please address some minor comments. > +(defcustom org-indent-post-buffer-init-hook nil > + "Hook run after org-indent finishes initializing a buffer. > +The function(s)

[PATCH] Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization

2024-01-02 Thread dark . key8799
On Sun, Dec 31, 2023, at 22:42, Ihor Radchenko wrote: > I do not see why we shouldn't add such a hook. Patches welcome! Would this work? -- Alexandre Avanian 0001-lisp-org-indent.el-Add-hook-to-run-after-it-initiali.patch Description: Binary data

Re: Suggestion to add hook to be run when org-indent completes a buffer's initialization

2023-12-31 Thread Ihor Radchenko
dark.key8...@151e.ai writes: > Although there are some workarounds for the particular issue above, a cleaner > solution would be org-indent calling some hook at the end of the preparation. > As per link above, jdtsmith proposes to add such call in > org-indent-initialize-buffer: > > ;;

Suggestion to add hook to be run when org-indent completes a buffer's initialization

2023-12-29 Thread dark . key8799
The org-modern-indent package relies on org-indent having finished preparing a buffer to add its own customizations. Currently it relies on a timer mechanism to watch org-indent-agentized-buffers and execute once a buffer has been prepped by org-indent. That leads to some downstream issues in p