>> OK, here's a better version. As you can see, it's not nearly as simple.
>
> Applied onto main + commits addressing all but one FIXME (the one about
> `find-file' in org-test.el).
Great, thanks,
Stefan
Stefan Monnier writes:
>> The fix is in preparation, but obviously I had tested my patch
>> incorrectly (i.e. I probably compiled and tested another code than the
>> one I had patched).
>
> OK, here's a better version. As you can see, it's not nearly as simple.
Applied onto main + commits addre
>> +;; FIXME: `s' is a symbol, so (car-safe s) is always nil.
>> +;;(when (eq 'autoload (car-safe s))
>> +;; (unintern s obarray))
>> +
>
> If I understand correctly, the intended version of this code is supposed
> to be
>
> (when (autoloadp (s
Stefan Monnier writes:
>> The fix is in preparation, but obviously I had tested my patch
>> incorrectly (i.e. I probably compiled and tested another code than the
>> one I had patched).
>
> OK, here's a better version. As you can see, it's not nearly as simple.
Thanks!
This new version passes
> The fix is in preparation, but obviously I had tested my patch
> incorrectly (i.e. I probably compiled and tested another code than the
> one I had patched).
OK, here's a better version. As you can see, it's not nearly as simple.
Stefan
>From 9cd41bcbb6ca6771bd4c79f8b9d07241c67250ea M
Ihor Radchenko [2022-09-14 20:32:53] wrote:
> Stefan Monnier writes:
>> The patch below simply enables `lexical-binding` in all the test files.
>> As far as I can tell, it's all that's needed (beside a missing
>> `require`).
> Thanks, but the patch causes 23 tests to fail (running make test).
Oh,
Stefan Monnier writes:
> The patch below simply enables `lexical-binding` in all the test files.
> As far as I can tell, it's all that's needed (beside a missing
> `require`).
Thanks, but the patch causes 23 tests to fail (running make test).
Also, is there any reason why it was a plain diff?
-
The patch below simply enables `lexical-binding` in all the test files.
As far as I can tell, it's all that's needed (beside a missing
`require`).
Stefan
diff --git a/testing/examples/babel.el b/testing/examples/babel.el
index a7bb0ccf52..cbd522e243 100644
--- a/testing/examples/babel.el
