Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-07-30 Thread Ihor Radchenko
David Lukeš writes: > Ihor: Thank you for the feedback! I'll send a proper patch then. Did you get a chance to work on this? Best, Ihor

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-21 Thread David Lukeš
Bruce: Understood, I was just thinking forward :) Thank you for the details. As far as I'm concerned, EDTF in CSL JSON sounds like a good idea (but it's not like my opinion should particularly matter). Ihor: Thank you for the feedback! I'll send a proper patch then. Best, David

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread Ihor Radchenko
David Lukeš writes: >> Would you mind creating a patch and possibly supplying a test >> that will make sure that the example file and similar are correctly >> parsed? > > I'm attaching a patch (just the patch for now, no commit message), let > me know what you think, in particular the error messa

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread Bruce D'Arcus
On Mon, Jun 20, 2022 at 10:13 AM David Lukeš wrote: ... > > it's likely we'll change the date property to prefer an > > EDTF string > > Will that be stored in the `raw` or `literal` field? In that case, the > current implementation should work with (not too wild) EDTF strings. > If not, code will

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread David Lukeš
> I created CSL, and have helped develop the data schema. Well, that's what I call a reliable source :) I suppose this is as good a time as any to say thanks for all that! > it's likely we'll change the date property to prefer an > EDTF string Will that be stored in the `raw` or `literal` field?

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread Bruce D'Arcus
On Mon, Jun 20, 2022 at 8:04 AM Ihor Radchenko wrote: > > "Bruce D'Arcus" writes: > > > I created CSL, and have helped develop the data schema. > > > > BTW, just to look forward, it's likely we'll change the date property > > to prefer an EDTF string; same as biblatex does now. > > Have you ever

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread Ihor Radchenko
"Bruce D'Arcus" writes: > I created CSL, and have helped develop the data schema. > > BTW, just to look forward, it's likely we'll change the date property > to prefer an EDTF string; same as biblatex does now. Have you ever checked if oc-basic parser complies with the schema? It is clear that i

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-20 Thread Ihor Radchenko
David Lukeš writes: >> The JSON schema allows either: > > Ah, thanks for looking this up! So (format "%s" (caar date)) instead > of (number-to-string (caar date))? > > (That was actually my initial solution, purely out of being defensive > and trying to make sure it doesn't break in yet a differe

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-19 Thread Bruce D'Arcus
On Sat, Jun 18, 2022 at 11:31 PM David Lukeš wrote: > > > I suspect that multiple json formats may be available in the wild. Some > > parsed as a list of strings and some parsed as a list of numbers. > > > The JSON schema allows either: > > Ah, thanks for looking this up! I created CSL, and have

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-18 Thread David Lukeš
> I suspect that multiple json formats may be available in the wild. Some > parsed as a list of strings and some parsed as a list of numbers. > The JSON schema allows either: Ah, thanks for looking this up! So (format "%s" (caar date)) instead of (number-to-string (caar date))? (That was actuall

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-18 Thread Bruce D'Arcus
On Sat, Jun 18, 2022 at 9:43 PM Ihor Radchenko wrote: > > David Lukeš writes: > > > I recently started to get errors like the following: > > > > Error during redisplay: (jit-lock-function 544) signaled > > (wrong-type-argument "Argument is not a string or a secondary string: > > 2007") > > > > Th

Re: oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-18 Thread Ihor Radchenko
David Lukeš writes: > I recently started to get errors like the following: > > Error during redisplay: (jit-lock-function 544) signaled > (wrong-type-argument "Argument is not a string or a secondary string: > 2007") > > This patch makes them go away: > > -

oc-basic: CSL-JSON year as number vs. string (nativecomp?)

2022-06-17 Thread David Lukeš
Hi all, I've run into more problems with CSL-JSON support in oc-basic (previously: https://list.orgmode.org/caeptpexczkgam3v-brzezfcwmm4h3hqtoq+89qg+5uljq1k...@mail.gmail.com/). I recently started to get errors like the following: Error during redisplay: (jit-lock-function 544) signaled (wrong-