Re: [POLL] Should we accept breaking changes to get rid of Org libraries that perform side effects when loading? (was: org-ctags land grab)

2023-03-28 Thread Ihor Radchenko
"Dr. Arne Babenhauserheide" writes: >> This is convincing. >> I am then CCing Bastien, as, despite the Elisp convention, following it >> will break https://bzg.fr/en/the-software-maintainers-pledge/ > > Isn’t the problem that the behavior changed — so that org-ctags gets > loaded in Emacs 30 but

Re: [POLL] Should we accept breaking changes to get rid of Org libraries that perform side effects when loading? (was: org-ctags land grab)

2023-03-27 Thread Dr. Arne Babenhauserheide
Ihor Radchenko writes: > Max Nikulin writes: > >>> Sure. This is not by itself a big deal. A number of Elisp libraries, >>> including built-in Emacs libraries are loaded with side effects. >> >> It is still violation of conventions: >> >> (info "(elisp) Coding Conventions") >>

[POLL] Should we accept breaking changes to get rid of Org libraries that perform side effects when loading? (was: org-ctags land grab)

2023-03-25 Thread Ihor Radchenko
Max Nikulin writes: >> Sure. This is not by itself a big deal. A number of Elisp libraries, >> including built-in Emacs libraries are loaded with side effects. > > It is still violation of conventions: > > (info "(elisp) Coding Conventions") >

Re: org-ctags land grab

2023-03-23 Thread Max Nikulin
On 23/03/2023 17:49, Ihor Radchenko wrote: Nick Dokos writes: It is off until org-ctags is loaded. *When* it is loaded, it runs `(org-ctags-enable)' and the behavior changes. Sure. This is not by itself a big deal. A number of Elisp libraries, including built-in Emacs libraries are loaded

Re: org-ctags land grab

2023-03-23 Thread Ihor Radchenko
Nick Dokos writes: >> It is off by default. > > It is off until org-ctags is loaded. *When* it is loaded, it runs > `(org-ctags-enable)' and the behavior changes. Sure. This is not by itself a big deal. A number of Elisp libraries, including built-in Emacs libraries are loaded with side

Re: org-ctags land grab

2023-03-22 Thread Nick Dokos
Ihor Radchenko writes: > Nick Dokos writes: > >> `org-ctags' unilaterally sets the hook `org-open-link-functions' to a >> bunch of org-ctags functions and enables itself by default. That has >> the unfortunate consequence of invalidating the documentation for >> internal CUSTOM_ID links - see

Re: org-ctags land grab

2023-03-22 Thread Ihor Radchenko
Nick Dokos writes: > `org-ctags' unilaterally sets the hook `org-open-link-functions' to a > bunch of org-ctags functions and enables itself by default. That has > the unfortunate consequence of invalidating the documentation for > internal CUSTOM_ID links - see > >

Re: org-ctags land grab

2023-03-21 Thread Rudolf Adamkovič
Nick Dokos writes: > It is also confusing. To quote the unfortunate victim: > > Now, when I click on the link, or C-c C-o, I get a dialog to "visit > tags table"... ??? I have had this happen to me many times too, so +1. Rudy -- "'Contrariwise,' continued Tweedledee, 'if it was so, it

org-ctags land grab

2023-03-20 Thread Nick Dokos
`org-ctags' unilaterally sets the hook `org-open-link-functions' to a bunch of org-ctags functions and enables itself by default. That has the unfortunate consequence of invalidating the documentation for internal CUSTOM_ID links - see