Ihor Radchenko writes:
> > Though, I think you didn't change the occurrence that this thread
> > started with - `org-eval'. Does changing this one cause problems?
>
> Tests are passing.
> I originally skipped it because it did not look useful from a brief
> glance to have full backtraces there,
Michael Heerdegen writes:
> Michael Heerdegen writes:
>
>> I reviewed it shortly - looks appropriate.
>
> Though, I think you didn't change the occurrence that this thread
> started with - `org-eval'. Does changing this one cause problems?
Tests are passing.
I originally skipped it because it
Michael Heerdegen writes:
> I reviewed it shortly - looks appropriate.
Though, I think you didn't change the occurrence that this thread
started with - `org-eval'. Does changing this one cause problems?
Michael.
Ihor Radchenko writes:
> I changed instances that appear to be safe.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b4eebfab
I reviewed it shortly - looks appropriate.
Thank you very much!
Michael.
Michael Heerdegen writes:
>> As for condition-case-unless-debug, may you create a patch?
>> But please do not replace everything blindly - I know for sure that at
>> least some `condition-case' clauses are there on purpose.
>
> I nearly never had a closer look at the org-mode code (other than
>
Ihor Radchenko writes:
> As for condition-case-unless-debug, may you create a patch?
> But please do not replace everything blindly - I know for sure that at
> least some `condition-case' clauses are there on purpose.
I nearly never had a closer look at the org-mode code (other than
blindly).
Michael Heerdegen writes:
> Ihor Radchenko writes:
>
>> What are those?
>> I do not have anything failing on my side.
>
> See the attached file. I had been using an up-to-date Emacs master build.
Ah. Different locale (LANG). It is
Ihor Radchenko writes:
> What are those?
> I do not have anything failing on my side.
See the attached file. I had been using an up-to-date Emacs master build.
Michael.
<>
Michael Heerdegen writes:
> Hmm - mine gave a different result: I cloned the org-mode archive from
> https://git.savannah.gnu.org/git/emacs/org-mode.git, called "make" and
> ran the tests as described in the "testing/README". That gave 6 failing
> tests.
What are those?
I do not have anything
Ihor Radchenko writes:
> In my attempts, the tests started failing for no obvious reason.
> Just from changing `condition-case' to `condition-case-unless-debug'.
>
> Though I did not investigate if it happened for every atomic change.
Hmm - mine gave a different result: I cloned the org-mode
Michael Heerdegen writes:
> Ihor Radchenko writes:
>
>> This is a good idea, except that `condition-case-unless-debug' has
>> non-obvious side effects that interfere with ERT (Org testing system).
>
> What side effects are these?
In my attempts, the tests started failing for no obvious reason.
Ihor Radchenko writes:
> This is a good idea, except that `condition-case-unless-debug' has
> non-obvious side effects that interfere with ERT (Org testing system).
What side effects are these?
Thx,
Michael.
Michael Heerdegen writes:
> I had a hard time to debug some problem with the expansion of some
> capture template because org catched the error even when I had set
> `debug-on-error'. Would it be possible to make some functions,
> e.g. `org-eval' in my case (probably some more?), use
>
Hello,
I had a hard time to debug some problem with the expansion of some
capture template because org catched the error even when I had set
`debug-on-error'. Would it be possible to make some functions,
e.g. `org-eval' in my case (probably some more?), use
`condition-case-unless-debug' instead
14 matches
Mail list logo
