Re: [PATCH] ob-python: support header argument `:results file graphics'

2023-07-13 Thread Jack Kamm
Ihor Radchenko writes: > We may instead arrange org-lint and possibly ob-core to throw a > warning when an src block uses confusing setting combinations. > Without changing the underlying behaviour. > Basically, discourage using confusing staff. > ... > We should update the docs to avoid such

Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Jack Kamm
Liu Hui writes: > Thanks for pointing out the problem! I find the problem disappears > after removing the `run-python` line, and I have updated the patch > accordingly. Thank you. I applied your patch to main branch. I am curious why the previous version of your test was causing hanging --

[Pre-PATCH v2] Add the capability to specify lexical scope in tangled files (was: Add new :lexical header argument)

2023-07-13 Thread General discussions about Org-mode.
Ihor Radchenko writes: > Evgenii Klimov writes: > >> * lisp/ob-core.el (org-babel-common-header-args-w-values): Add new >> :lexical header argument. > > A short note: ob-emacs-lisp already defines :lexical header arg. See > org-babel-header-args:emacs-lisp. Thanks for pointing it out. Updated

Re: [Pre-PATCH] Add new :lexical header argument

2023-07-13 Thread Ihor Radchenko
Evgenii Klimov writes: > * lisp/ob-core.el (org-babel-common-header-args-w-values): Add new > :lexical header argument. A short note: ob-emacs-lisp already defines :lexical header arg. See org-babel-header-args:emacs-lisp. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about

[Pre-PATCH] Add new :lexical header argument

2023-07-13 Thread Evgenii Klimov
Hi, here I propose new header argument to enable scope change (lexical/dynamic binding) of the tangled file. We have :shebang header argument and the new one behaves similarly. If you like the idea I think we should discuss the following: - should we allow to set it for non-elisp blocks? e.g.

Re: [PATCH] org.el: Remove undefined dynamic variable `org-log-states' from example

2023-07-13 Thread Ihor Radchenko
Evgenii Klimov writes: > Ihor Radchenko writes: > >> It looks like 5 working days have passed since your email to FSF. If so, >> please follow up once and wait another 5 working days. > > I've got papers from FSF, signed it and sent it back. It was 6 working > days ago. 5 days that you mention

Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-07-13 Thread Jonathan Gregory
Hi On 13 Jul 2023, Ihor Radchenko wrote: Jonathan Gregory writes: Can you check if adding: \version "2.24.1" #(ly:set-option 'use-paper-size-for-page #f) #(ly:set-option 'tall-page-formats 'pdf) to the version-and-paper block fixes the issue. Yes, except that I have lilypond 2.24.0,

[PATCH v2] ob-tangle.el: Blocks overwrite each other when grouping before tangling

2023-07-13 Thread Evgenii Klimov
In this version I just updated the docstrings for the relevant functions, because prior to that it wasn't clear: does this "default export file for *all* source blocks" influence blocks with :tangle "yes"/FILENAME? >From 1a4f76960cf11fb192f2bee2cdc8778c7b897f1a Mon Sep 17 00:00:00 2001 From:

Improve org-insert-link completion (was: [Bug] org-insert-link removes on one link from 2 added by org-store-link)

2023-07-13 Thread Ihor Radchenko
Samuel Wales writes: > link has already been stored is a bug in my case in that i can't just > go to a header, grab it [whether rabbed bfere or not] and then paste > it. i surprise easily when the wrong link gets pasted. This has been fixed already. > in answer to a q by ihor, indeed puttig

Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-07-13 Thread Ihor Radchenko
Jonathan Gregory writes: > Can you check if adding: > > \version "2.24.1" > #(ly:set-option 'use-paper-size-for-page #f) > #(ly:set-option 'tall-page-formats 'pdf) > > to the version-and-paper block fixes the issue. Yes, except that I have lilypond 2.24.0, which failed until I changed the

Re: [PATCH] ob-python: Fix async evaluation

2023-07-13 Thread Liu Hui
Jack Kamm 于2023年7月13日周四 05:58写道: > While your test works on its own, it seems to break subsequent tests > (the next test hangs). Thanks for pointing out the problem! I find the problem disappears after removing the `run-python` line, and I have updated the patch accordingly. From

Re: [PATCH] testing: Delete duplicate tests

2023-07-13 Thread Ihor Radchenko
Ilya Chernyshov writes: > In my last patch, I found a duplicate test, so I decided to find all of > the duplicate tests inside testing/lisp/ folder via this function: Thanks! > --- a/testing/lisp/test-org-table.el > +++ b/testing/lisp/test-org-table.el > @@ -3368,10 +3368,6 @@ See also

Re: [BUG] WORG example for ob-lilypond is no longer working as described

2023-07-13 Thread Jean Abou Samra
Le jeudi 13 juillet 2023 à 08:33 +0200, Dr. Arne Babenhauserheide a écrit : > This is the lilypond-file in questoin: > https://hg.sr.ht/~arnebab/draketos-songbook/browse/delfini-tune.ly?rev=tip > > Converted to PNG in a two step process: > lilypond -dbackend=eps -dno-gs-load-fonts

Re: [BUG] WORG example for ob-lilypond is no longer working as described

2023-07-13 Thread Dr. Arne Babenhauserheide
"Dr. Arne Babenhauserheide" writes: > Ihor Radchenko writes: > >> "Dr. Arne Babenhauserheide" writes: >> >>> I typically use it directly, but if the maintenance burden is >>> manageable, I could offer maintenance here, too (once I have the papers >>> in place). >> >> I have recently seen

Re: [BUG] WORG example for ob-lilypond is no longer working as described (was: Moving some lisp/ob-*.el files to org-contrib - your advice?)

2023-07-13 Thread Dr. Arne Babenhauserheide
Jonathan Gregory writes: > Hi Ihor > > On 12 Jul 2023, Ihor Radchenko wrote: > > [...] > >> I have recently seen https://masto.ai/@rfc1149/110674961710491363 >> that revealed a problem with example from >> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-lilypond.html#org29a742f >>

Re: [BUG] WORG example for ob-lilypond is no longer working as described

2023-07-13 Thread Dr. Arne Babenhauserheide
Ihor Radchenko writes: > "Dr. Arne Babenhauserheide" writes: > >> I typically use it directly, but if the maintenance burden is >> manageable, I could offer maintenance here, too (once I have the papers >> in place). > > I have recently seen https://masto.ai/@rfc1149/110674961710491363 that >