Re: Adding custom providers for thingatpt.el

2024-05-21 Thread Jim Porter
On 5/21/2024 3:32 AM, Max Nikulin wrote: On 20/05/2024 09:33, Jim Porter wrote: +++ b/lisp/org.el @@ -81,6 +81,7 @@  (require 'calendar)  (require 'find-func)  (require 'format-spec) +(require 'thingatpt) So it becomes hard dependency. However it seems thingatpt is anyway loaded through some

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-05-20 Thread Jim Porter
On 5/20/2024 3:41 AM, Ihor Radchenko wrote: Jim Porter writes: + (when (boundp 'forward-thing-provider-alist) +(setq-local forward-thing-provider-alist +(cons '(url . org-next-link) + forward-thing-provider-alist))) According to the docstring

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-05-19 Thread Jim Porter
On 5/19/2024 6:34 PM, Jim Porter wrote: On 5/18/2024 1:26 AM, Eli Zaretskii wrote: I think you can install this now. Thanks. Merged as ae9045a8bd8. Ihor, I'll update the Org-mode part of this next and post the new patch for that to the Org list once it's ready. ... and here's the Org-mode

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-05-19 Thread Jim Porter
On 5/18/2024 1:26 AM, Eli Zaretskii wrote: I think you can install this now. Thanks. Merged as ae9045a8bd8. Ihor, I'll update the Org-mode part of this next and post the new patch for that to the Org list once it's ready.

Re: [External] : Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-05-07 Thread Jim Porter
On 5/7/2024 5:20 AM, Eli Zaretskii wrote: I disagree. These functions are nowadays the basis of many interactive features, and users are usually mightily confused by the fine print of what "at point" means technically in Emacs. The current operation is much easier for users to grasp mentally

Re: RE: [External] : Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-05-06 Thread Jim Porter
On 4/30/2024 2:10 PM, Drew Adams wrote: I've also fixed a bug in EWW and bug-reference-mode where it would return nil for (thing-at-point 'url) if point was at the *end* of a URL. By "at the end" I assume you really mean just _after_ a URL, i.e., no longer on/at the URL. FWIW, that's actually

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-30 Thread Jim Porter
21 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Sun, 28 Apr 2024 21:19:53 -0700 Subject: [PATCH] Allow defining custom providers for more "thingatpt" functions This also fixes an issue in EWW and bug-reference-mode where (thing-at-point 'url) at the end of a URL would return nil.

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-29 Thread Jim Porter
here could be some bugs lurking in here...From ad8db930907cd760142fd6f035d97ce93ce8d850 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Sun, 28 Apr 2024 21:19:53 -0700 Subject: [PATCH] Allow defining custom providers for more "thingatpt" functions * lisp/thingatpt.el (forward-thing-pro

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-28 Thread Jim Porter
On 4/12/2024 3:30 PM, Jim Porter wrote: On 4/12/2024 5:41 AM, Ihor Radchenko wrote: Jim Porter writes: That sounds reasonable enough to me; does anyone else have opinions on this? Otherwise, I'll get to work on a patch (though probably not for a couple weeks). It has been a while since

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-12 Thread Jim Porter
On 4/12/2024 5:41 AM, Ihor Radchenko wrote: Jim Porter writes: That sounds reasonable enough to me; does anyone else have opinions on this? Otherwise, I'll get to work on a patch (though probably not for a couple weeks). It has been a while since the last message in this thread. Jim, may I

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-02-05 Thread Jim Porter
On 2/5/2024 7:07 AM, Ihor Radchenko wrote: It would make sense to add a number of alists: - bounds-of-thing-at-point-provider-alist - same for 'forward-op, 'beginning-op, 'end-op. After Emacs have those, we can add Org mode support. That sounds reasonable enough to me; does anyone else have

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2023-11-06 Thread Jim Porter
On 11/6/2023 12:11 PM, Ihor Radchenko wrote: [ Branching to emacs-devel for further input from Emacs devs ] Jim Porter writes: This is similar to Emacs bug#66752[1]. It would be nice if "(thing-at-point 'url)" would return the URL when point is over an Org link. With this, i

Re: [PATCH] Add support for 'thing-at-point' to get URL at point

2023-11-06 Thread Jim Porter
On 11/6/2023 11:45 AM, Jim Porter wrote: This is similar to Emacs bug#66752[1]. It would be nice if "(thing-at-point 'url)" would return the URL when point is over an Org link. With this, it's easier to write a function that copies (or browses to) the URL at point without codi

[PATCH] Add support for 'thing-at-point' to get URL at point

2023-11-06 Thread Jim Porter
is a patch with a regression test for it. Should this also get a NEWS entry? [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2023-10/msg01628.htmlFrom 6bce84bd28253236eff8ef972ede7daf82f95a71 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Mon, 6 Nov 2023 11:39:09 -0800 Subject: [PATCH] Add support

Re: Lazy load of org-protocol

2022-02-09 Thread Jim Porter
On 2/9/2022 8:46 AM, Max Nikulin wrote: It is not a problem to implement --apply in addition to --arg. [snip] For the purposes of this issue, I think either solution would probably work. It probably depends on what people think on emacs-devel. On a related note, there is still an issue with

Re: Lazy load of org-protocol

2022-02-07 Thread Jim Porter
On 2/7/2022 6:57 AM, Max Nikulin wrote: Maybe another option would be to add an --apply argument that really *does* consume the other command-line args and turns them into a properly-quoted function call. Roughly speaking, it would turn this:    emacs --apply func foo bar baz into this:   

Re: Lazy load of org-protocol

2022-02-06 Thread Jim Porter
On 2/6/2022 8:42 AM, Max Nikulin wrote: On 06/02/2022 01:27, Jim Porter wrote: As a result, I think a good first step might be to add support for "--funcall" to emacsclient, just like the regular emacs binary. (The "-f" shorthand won't work though, since emac

Re: Lazy load of org-protocol

2022-02-05 Thread Jim Porter
On 2/5/2022 3:54 AM, Max Nikulin wrote: I would prefer to avoid    (require 'org-protocol) in emacs init file and to postpone loading till invocation of emacsclient with org-protocol URI. The problem is a hack in org-protocol. URIs are actually treated as (relative) file names and magic is

Re: Suggestion: convert dispatchers to use transient

2022-02-03 Thread Jim Porter
On 2/3/2022 1:30 PM, Tim Cross wrote: Is the transient.el included in Emacs 28 the same as the one on GNU ELPA? Currently, yes. They're both 0.3.7. However, that could obviously change in the future (e.g. a user on 28.1 would likely have transient 0.3.7, though GNU ELPA might have transient

Re: Suggestion: convert dispatchers to use transient

2022-02-03 Thread Jim Porter
On 2/3/2022 2:07 AM, Tim Cross wrote: After 28.0 is released, if transient is a GNU ELPA package, we can probably just make it an org dependency and Emacs 26.x and 27.x should be able to install and run it (would need to be verified). The transient package is on GNU ELPA already[1], and based

Re: "Orgdown", the new name for the syntax of Org-mode

2021-11-28 Thread Jim Porter
On 11/28/2021 11:46 AM, Karl Voit wrote: At this year's EmascsConf, I had a 12 minute video where I explain why we do need a different name for the syntax of Org-mode in contrast to the Elisp implementation of GNU/Emacs Org-mode. I would like you to read my rationale and motivate you to use the

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-26 Thread Jim Porter
On 9/25/2021 10:58 PM, Bastien wrote: I applied the patch adding the TINYCHANGE cookie, since the assignment process isn't done yet. Can you check with copyright-cl...@fsf.org if it will be done anytime soon? Hm, it should be done, since I received confirmation from the copyright clerk on

Re: DONE headlines take a different color

2021-09-19 Thread Jim Porter
On 9/19/2021 9:09 AM, Giovanni Gigante wrote: As per the subject: TODO states mantain the headline color (as expected), but DONE states change it (not expected). As shown in lines 2, 5, 8, 11, 14 of the following screenshot (emacs 27.2 on MacOS launched with -q,  org mode 9.4.4): I

Re: [PATCH] Improve org-mouse support for checkboxes

2021-09-18 Thread Jim Porter
On 9/18/2021 1:54 PM, Samuel Wales wrote: thanks for this. if tests are written, might be useful to include the case where half-checked are parents. I tested manually, and this behaves how I'd expect; not surprising, since it just calls `org-toggle-checkbox'. Maybe there's an argument that

[PATCH] Improve org-mouse support for checkboxes

2021-09-18 Thread Jim Porter
wasn't sure though, so I went with the simpler solution for now. My FSF copyright assignment should be on file, but let me know if there are any issues there. From b2bd5115a89b9b26107aca4b59e516dc7d64f0cc Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Sat, 18 Sep 2021 12:22:41 -0700 Subject: [PATCH] o

Re: [PATCH] Rename headline to heading

2021-08-15 Thread Jim Porter
On 8/15/2021 4:17 PM, Tim Cross wrote: At some point, your transition period will end. If it isn't with the transition to v9.5, it will be the transition to 9.6. At this point, all of the issues you point out will still exist. There will still be people who are running multiple versions, there

Re: [PATCH] Rename headline to heading

2021-08-15 Thread Jim Porter
On 8/14/2021 3:54 PM, Tim Cross wrote: I'm not convinced a transition period will help in this case. At some point, users will need to update their capture templates regardless. Provided this impact is clearly outlined in the NEWS.org file (I think there should be a specific reference to capture

Re: [POLL] Setting `org-adapt-indentation' to nil by default?

2021-05-02 Thread Jim Porter
On 5/1/2021 11:09 PM, Bastien wrote: With `electric-indent-mode' being activated by default in Emacs, the current behavior is that RET after a headline moves the point below the beginning of this headline, not the beginning of the line, which might surprise users. Indentation is quite