Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread General discussions about Org-mode.
Ihor Radchenko writes: >> +(defun org-columns--substring-below-width (string start width) >> + "Similar to `substring', but use `string-width' to check width. > > This is not really similar to `substring' as `substring' has totally > different third argument. Addressed in v6 -- see my update

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-25 Thread Ihor Radchenko
Ruijie Yu writes: > Just had a try at this, fully untested code (other than starting a > LANG=zh_CN.UTF-8 Emacs session and running this substring function to > see its effects). Thanks! > +(defun org-columns--substring-below-width (string start width) > + "Similar to `substring', but use

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-23 Thread General discussions about Org-mode.
Ihor Radchenko writes: > Ruijie Yu writes: > >>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63029 >> >> From my understanding of Eli's response, org-colview is at fault here, by >> calling `length' instead of `string-width' in >> `org-columns-add-ellipses'. Changing this function call

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-23 Thread Ihor Radchenko
Ruijie Yu writes: >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63029 > > From my understanding of Eli's response, org-colview is at fault here, by > calling `length' instead of `string-width' in > `org-columns-add-ellipses'. Changing this function call might be all it > needs to fix the

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-23 Thread General discussions about Org-mode.
Ihor Radchenko writes: > Ruijie Yu writes: > (format "%-5.5s |" "1234…") returns different results for different locales, causing `test-org-colview/columns-width' to break. >>> >>> What are these different results? >> >> In CJK locales such as zh_CN and ja_JA, the

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-23 Thread Ihor Radchenko
Ruijie Yu writes: >>> (format "%-5.5s |" "1234…") >>> >>> returns different results for different locales, causing >>> `test-org-colview/columns-width' to break. >> >> What are these different results? > > In CJK locales such as zh_CN and ja_JA, the ellipsis character is > truncated, and

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-23 Thread Ihor Radchenko
Ruijie Yu via "General discussions about Org-mode." writes: > Second, `org-columns--overlay-text' has a problem where > > (format "%-5.5s |" "1234…") > > returns different results for different locales, causing > `test-org-colview/columns-width' to break. What are these different results?

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-22 Thread General discussions about Org-mode.
Axel Kielhorn writes: >> Am 22.04.2023 um 15:01 schrieb Ruijie Yu via General discussions about >> Org-mode. : >> >> >> Ruijie Yu via "General discussions about Org-mode." >> writes: >> >>> Ruijie Yu via "General discussions about Org-mode." >>> writes: >>> Ruijie Yu via "General

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-22 Thread Axel Kielhorn
> Am 22.04.2023 um 15:01 schrieb Ruijie Yu via General discussions about > Org-mode. : > > > Ruijie Yu via "General discussions about Org-mode." > writes: > >> Ruijie Yu via "General discussions about Org-mode." >> writes: >> >>> Ruijie Yu via "General discussions about Org-mode."

Re: [DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-22 Thread General discussions about Org-mode.
Ruijie Yu writes: > Here is an updated patch (replacing the first iteration). This should > hopefully fix both test failures that Axel found. Once this is > confirmed good, I will look at the test failures of the other languages > to see what I can do. > > [2. text/x-patch; >

[DRAFT PATCH v2] Decouple LANG= and testing (was: Test failure due to LANG)

2023-04-22 Thread General discussions about Org-mode.
Ruijie Yu via "General discussions about Org-mode." writes: > Ruijie Yu via "General discussions about Org-mode." > writes: > >> Ruijie Yu via "General discussions about Org-mode." >> writes: >> >>> Axel Kielhorn writes: >>> Hello! I’m building org with LANG=de. As a