Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: >> Will the failure disappear if you try the attached patch? >> [...] > > Yes, your patch fixes that test failure on macOS. Thanks for checking! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=d8ac95883 -- Ihor Radchenko // yantar92,

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > Alexander Adolf writes: > >> 4 unexpected results: >>FAILED ob-calc/matrix-inversion ((should (equal "[[-1, 0.625, -0.125], >> [0.25, -0.5, 0.25], [0.5, 0.125, -0.125]]" (org-babel-execute-src-block))) >> :form (equal "[[-1, 0.625, -0.125], [0.25, -0.5, 0.25],

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > 4 unexpected results: >FAILED ob-calc/matrix-inversion ((should (equal "[[-1, 0.625, -0.125], > [0.25, -0.5, 0.25], [0.5, 0.125, -0.125]]" (org-babel-execute-src-block))) > :form (equal "[[-1, 0.625, -0.125], [0.25, -0.5, 0.25], [0.5, 0.125, > -0.125]]" "[[-1,

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > One last question though: I'm developing an add-on package which will > use the new features. I guess in "Package-Requires:" it should say > (org "9.7") ? Yes. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > Bastien Guerry writes: > >> Ihor Radchenko writes: >> >>> Thanks! >>> The patch is ready to be merged. >>> Bastien, may you please confirm the FSF records? >>> Alexander should have the copyright signed. >> >> Yes, he has, thanks! > > Applied, onto main. > [...] >

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Bastien Guerry writes: > Ihor Radchenko writes: > >> Thanks! >> The patch is ready to be merged. >> Bastien, may you please confirm the FSF records? >> Alexander should have the copyright signed. > > Yes, he has, thanks! Applied, onto main.

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > Thanks! > The patch is ready to be merged. > Bastien, may you please confirm the FSF records? > Alexander should have the copyright signed. Yes, he has, thanks! -- Bastien Guerry

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > Ihor Radchenko writes: > >> [...] If you can, please add some more tests like mine checking `org-columns--clean-item'. >> [...] > > I have added one test for each new feature (headline linkification, and > formatting function). Also, there's a third patch,

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > [...] >>> If you can, please add some more tests like mine checking >>> `org-columns--clean-item'. > [...] I have added one test for each new feature (headline linkification, and formatting function). Also, there's a third patch, which moves the call to `org-quote-vert'

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: >>> + (let ((search (org-link-heading-search-string >>> raw))) >>> +(org-link-make-string >>> + (if (not (buffer-file-name)) search >>> + (format "file:%s::%s"

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > [...] > It would make sense then to include `org-quote-vert' call into > `org-columns--clean-item' then. Good point. I'll move the call to `org-quote-vert' there. > [...] >> (defun org-columns--capture-view (maxlevel match skip-empty exclude-tags >> format local) >>

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > Ihor Radchenko writes: > >> [...] >> Calling `org-columns--clean-item' is a must to create a valid table. > > True. > > Additionally, it would seem advisable to call `org-quote-vert' on the > data, too, as `org-columns--clean-item' does not take care of vertical >

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > [...] > Calling `org-columns--clean-item' is a must to create a valid table. True. Additionally, it would seem advisable to call `org-quote-vert' on the data, too, as `org-columns--clean-item' does not take care of vertical bars? This is done in a previous step in

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > Ah, `org-column--clean-item'; well spotted! > > Two observations: > > 1) As is now, I'm generating the links in the data collection function >`org-columns--capture-view'. As `org-column--clean-item' is called >from code that runs after the data collection, >

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Many thanks for your swift response! Ihor Radchenko writes: > [...] > When suggesting #+vindex, I was referring to > org-columns-dblock-formatter variable. > [...] > #+cindex: @samp{formatter}, dynamic block parameter I see; thanks for explaining. I've added both:

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > [...] >> `make compile` didn't complain at all, and `make test` ended with the >> following: >> ... >> 4 unexpected results: >>FAILED ob-calc/matrix-inversion >>FAILED test-ob-shell/bash-uses-assoc-arrays >>FAILED

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: >> Also, if you mention a variable in the manual, please add #+vindex: >> entry. Maybe even #+cindex: entry for "formatter", to make the parameter >> more discoverable. > > I kept it to the format of the existing parameter descriptions, which > don't create index entries.

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > Alexander Adolf writes: > >> Subject: [PATCH 1/2] lisp/org-colview.el: add formatter parameter to colview >> dynamic block > > Thanks for the patches! > See my comments below. Thanks for your swift review, and most helpful comments! While I'm implementing these,

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > Subject: [PATCH 1/2] lisp/org-colview.el: add formatter parameter to colview > dynamic block Thanks for the patches! See my comments below. > * lisp/org-colview.el (org-dblock-write:column view): Factor out the > existing formatting code to new function >

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Many thanks for the pointers, Ihor! The instructions were clear and concise, so the patch creation went smoothly. Results attached below. I cloned the Org repository from git://git.sv.gnu.org/emacs/org-mode.git and followed the instructions at

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: >> In any case, making column views more flexible is welcome. >> [...] > >  Lure me into contributing a patch? fair enough; I might just as well > give that a try. I presume I'd get some support here on this list? > And/or on IRC (e.g. libera.chat#org-mode)? Yup. You

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Ihor Radchenko writes: > Alexander Adolf writes: > >>> In fact, CLOCKSUM property does not support custom summaries. >> >> ??? > > AFAIU, you cannot do %CLOCKSUM{max}. Ah, I see; that's what you meant. >> [...] >> Thus, from my point of view, having a :formatter for the columnview >> dblock

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: >> In fact, CLOCKSUM property does not support custom summaries. > > ??? AFAIU, you cannot do %CLOCKSUM{max}. >>> Is there any way to change the summation behaviour for either or both >>> column types? >> >> It is currently hard-coded. (Although, it is not too hard add

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Hello Ihor, Many thanks for your swift response. Ihor Radchenko writes: > [...] >> Does anyone recall the rationale for this different behaviour? > > The "default" behaviour is to store summary of all the child property > value in each parent. > [...] > This is, however, not possible for

Re: columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Alexander Adolf writes: > it seems that the time summing behaviour of columnview dynamic blocks is > different for CLOCKSUM than for EFFORT columns with respect to how the > contributions from sub-headlines are handled. When summing up CLOCKSUM > columns, a parent headline can have its own

columnview dynamic block - different time summing behaviour for EFFORT and CLOCKSUM

Hello Org experts, it seems that the time summing behaviour of columnview dynamic blocks is different for CLOCKSUM than for EFFORT columns with respect to how the contributions from sub-headlines are handled. When summing up CLOCKSUM columns, a parent headline can have its own clocked time, which