Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-30 Thread Eli Zaretskii
> Date: Mon, 28 Aug 2006 18:09:19 +0200 > From: Lennart Borgman <[EMAIL PROTECTED]> > Cc: emacs-pretest-bug@gnu.org, "Kim F. Storm" <[EMAIL PROTECTED]> > > - Is there not a unix style shell for DOS too? Yes, there's a DOS port of Bash. However, the users of the DOS port of Emacs (if there still

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-30 Thread Eli Zaretskii
> Date: Mon, 28 Aug 2006 15:37:02 +0100 > From: Jason Rumney <[EMAIL PROTECTED]> > Cc: "Kim F. Storm" <[EMAIL PROTECTED]>, emacs-pretest-bug@gnu.org > > The only thing left is to silence the compiler warning about > w32-shell-dos-semantics not being defined on other platforms. Is > (defun w32-shel

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-28 Thread Lennart Borgman
Jason Rumney wrote: Jason Rumney wrote: We already have w32-system-shells, which is the inverse of the variable you propose (except it is missing "cmdproxy.exe", I am not sure if there is a good reason for that). In fact we have a function w32-shell-dos-semantics for precisely this purpose. So

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-28 Thread Jason Rumney
Jason Rumney wrote: We already have w32-system-shells, which is the inverse of the variable you propose (except it is missing "cmdproxy.exe", I am not sure if there is a good reason for that). In fact we have a function w32-shell-dos-semantics for precisely this purpose. So a suitable patch mig

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-28 Thread Jason Rumney
Lennart Borgman wrote: 1) A new function quote-special-characters that will quote characters like (); if it is a unix style shell. If we DTRT in shell-quote-argument, then we don't need to introduce further complication. 2) A new function w32-shell-is-unix-style that looks at shell-file-nam

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-28 Thread Kim F. Storm
Lennart Borgman <[EMAIL PROTECTED]> writes: >> find . ( -type f -exec grep -q -e "message" {} ; ) -exec ls -ld {} ; > > Thanks, that expression works with the GnuWin32 port of GNU find and > CMD.exe. > > To remove the bugs I suggest the following approach: > > 1) A new function quote-special-chara

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-27 Thread Lennart Borgman
Jason Rumney wrote: Lennart Borgman wrote: In any case the command string that is built and send to CMD does not work. Here I am using the GnuWin32 port of find, version 4.2.20. Find complains about the first -exec: find . \( -type f -exec grep -q -e "message" {} \; \) -exec ls -ld {} \;

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-27 Thread Jason Rumney
Lennart Borgman wrote: In any case the command string that is built and send to CMD does not work. Here I am using the GnuWin32 port of find, version 4.2.20. Find complains about the first -exec: find . \( -type f -exec grep -q -e "message" {} \; \) -exec ls -ld {} \; find: missing ar

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-27 Thread Lennart Borgman
Jason Rumney wrote: Lennart Borgman wrote: I think there is a bug in shell-quote-argument that is used here. This function does not care about shell-file-name. How can quoting succeed if it does not do that? Indeed, that is a problem, as is the blind wrapping in double quotes on w32 when ms-

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-27 Thread Jason Rumney
Lennart Borgman wrote: I think there is a bug in shell-quote-argument that is used here. This function does not care about shell-file-name. How can quoting succeed if it does not do that? Indeed, that is a problem, as is the blind wrapping in double quotes on w32 when ms-dos has a much more c

Re: Can't stop find-grep-dired when using Cygwin for the inferior process - bug in shell-quote-argument?

2006-08-27 Thread Lennart Borgman
Lennart Borgman wrote: Jason Rumney wrote: Lennart Borgman wrote: There seem to be another bug on w32 too. I just tried using CMD.EXE for the inferior process instead. That does not seem to work at all. I got this: d:/ecvs/: find . \( -type f -exec grep -q -e "message" {} \; \) -exec ls -