Well, I don't really care what you do with my bug report, but my point is
that (I believe that) it does *not* reliably do the right thing. It does the
right thing only if there is in fact no list of faces that matches
((foreground-color . Firebrick)...).
They have different data
Well, I don't really care what you do with my bug report,
but my point is
that (I believe that) it does *not* reliably do the right
thing. It does the
right thing only if there is in fact no list of faces that matches
((foreground-color .
To test this, do M-x debug-on-entry read-face-name, and then M-x
customize-face font-lock-comment-face. Then, put point on the
second sample text (next to the foreground field), and do M-:
(read-face-name foo). Step through the debugger,
To test this, do M-x debug-on-entry read-face-name,
and then M-x
customize-face font-lock-comment-face. Then, put point on the
second sample text (next to the foreground field),
and do M-:
(read-face-name foo).
2. I think the code is wrong for the case where there is a face
property like this on the character: ((foreground-color
Firebrick)).
It seems to give the right results: it finds no face names
and `faces' is empty.
In what way do you think this is incorrect?
To test
2. I think the code is wrong for the case where there is a face
property like this on the character: ((foreground-color
Firebrick)).
It seems to give the right results: it finds no face names
and `faces' is empty.
In what way do you think this is
I didn't say it was crucial; I said it was inconsistent and inconvenient.
Why create an exceptional interface and then have to add stuff in the doc
string to compensate for the confusion that exception introduces? What is
gained by this?
It is convenient for the places it is
1. read-face-name's prompt arg should be like every other prompt
arg. It should not automatically add a colon and space. Besides,
the doc string mentions that you shouldn't add a space (without
saying why), but it neglects to mention that you shouldn't add a
colon
1. read-face-name's prompt arg should be like every other prompt
arg. It should not automatically add a colon and space. Besides,
the doc string mentions that you shouldn't add a space (without
saying why), but it neglects to mention that you shouldn't add
