> I wonder what do the users of transient-mark-mode with
> mark-even-if-inactive=t expect in this situation?
In transient-mark-mode, the current behavior in general is that
mark-even-if-inactive is only used for commands which require a region.
For those commands whose behavior varies depending o
2005 07:59:56 - 1.24
--- lisp/log-view.el4 Dec 2005 21:44:45 -
***
*** 195,204
;;
(defun log-view-diff (beg end)
! "Get the diff for several revisions.
! If the point is the same as the mark or the mark is not active,
! get the diff for this revision.
> The doc for log-view-diff says:
>
> "Get the diff for several revisions.
> If the point is the same as the mark, get the diff for this revision.
> Otherwise, get the diff between the revisions
> were the region starts and ends."
>
> bu
"get the diff between the revision at point and the next revision"
Wouldn't it be more natural to compare with the previous revision?
That would show you the changes installed _in_ the revision
that you're pointing at.
___
emacs-pretest-bug mailing
> > > Why require mark to be active to diff between two specified revisions?
> >
> > Because it's very convenient to be able to do a diff between rev N and
> > current (rather between rev N1 and N2) without having to set the
> > mark locally.
>
> OK, I see now. I've installed Juri's doc stri
The doc for log-view-diff says:
"Get the diff for several revisions.
If the point is the same as the mark, get the diff for this revision.
Otherwise, get the diff between the revisions
were the region starts and ends."
but the implementation requires that mark
> > Why require mark to be active to diff between two specified revisions?
>
> Because it's very convenient to be able to do a diff between rev N and
> current (rather between rev N1 and N2) without having to set the
> mark locally.
OK, I see now. I've installed Juri's doc string patch.
Ni
>> > > What about the following docstring? It should correctly document what
>> > > this function does.
>> >
>> > Why require mark to abe active?
>>
>> Actually, it doesn't require mark to be active. When mark is not active,
>> it uses the revision at point.
> I mean:
> Why require mark to b
rk-active' is useful in this function for transient-mark-mode,
> because end points are only meaningful if the mark is active in
> transient-mark-mode.
The end points are still meaningful, they're just don't delimit a highlighted
region. I can find mark by doing C-x C-x.
where the order of the marked file and the file at point
can be reversed if needed, in log-view-diff the order is fixed with
the more recent revision always going to the second argument of
`vc-version-diff', and the older revision to its first argument.
BTW, dired-diff has a significant incon
l 2 Dec 2005 00:33:33 -
> ***
> *** 196,204 ****
>
> (defun log-view-diff (beg end)
> "Get the diff for several revisions.
> ! If the point is the same as the mark, get the diff for this revision.
> ! Otherwise, get the diff between the revisions
>
> The doc for log-view-diff says:
>
> "Get the diff for several revisions.
> If the point is the same as the mark, get the diff for this revision.
> Otherwise, get the diff between the revisions
> were the region starts and ends."
>
> but the implement
I just noticed there was a typo in the original docstring. Should be
not "were the region starts and ends", but "where the region starts and ends".
--
Juri Linkov
http://www.jurta.org/emacs/
___
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.o
The doc for log-view-diff says:
"Get the diff for several revisions.
If the point is the same as the mark, get the diff for this revision.
Otherwise, get the diff between the revisions
were the region starts and ends."
but the implementation requires that mark is active:
(i
14 matches
Mail list logo
