Re: [Engine-devel] Introducing virt / gluster flags at cluster level

2012-03-01 Thread Itamar Heim
On 03/01/2012 12:54 PM, Shireesh Anjal wrote: Hi, In order to identify whether a cluster exposes Gluster / Virtualization capabilities, we plan to introduce two boolean columns - virt_service and gluster_service in the vds_groups table. As per immediate plans, it is intended to support only one

[Engine-devel] Use java.util.Collection where possible?

2012-03-01 Thread Yair Zaslavsky
Hi, I see that in some places in engine-core we use Java.Util.List, or even Java.Util.ArrayList as types of method arguments, while in the method code we do nothing besides iterating over the collection. I then found all kinds of usages like this: x.foo(new ArrayList(myMap.values())); As you can

[Engine-devel] Introducing virt / gluster flags at cluster level

2012-03-01 Thread Shireesh Anjal
Hi, In order to identify whether a cluster exposes Gluster / Virtualization capabilities, we plan to introduce two boolean columns - virt_service and gluster_service in the vds_groups table. As per immediate plans, it is intended to support only one service per cluster, meaning only one of th

Re: [Engine-devel] synthetic-access

2012-03-01 Thread Allon Mureinik
- Original Message - > From: "Mike Kolesnik" > To: "Yair Zaslavsky" > Cc: "engine-devel" > Sent: Wednesday, February 29, 2012 7:39:37 PM > Subject: Re: [Engine-devel] synthetic-access > > > On 02/29/2012 04:23 PM, Laszlo Hornyak wrote: > > > Hi, > > > > > > I am reviewing Allon's pat